GNOME Bugzilla – Bug 362639
Fixes compiling with forte: warning clean up (part 6)
Last modified: 2006-10-16 18:08:19 UTC
Please describe the problem: gst/iec958/ac3_padder.c: changed char for unsigned char gst/mpegstream/gstmpegparse.c: diferent return type between declaration and definition gst/realmedia/rmdemux.c: arithmethics with a void pointer Steps to reproduce: Compile it with Forte Actual results: Expected results: Does this happen every time? Other information:
Created attachment 74824 [details] [review] [patch] Fixes the bugs
Yuk, instead of all those ugly casts in rmdemux.c maybe you could modify some of the gpointer foo function arguments to guint8 * ? I don't think there's really a reason why we use gpointer or void * there. Also, changing those to guint8 * will more likely keep things compiling in future when people change things ...
Created attachment 74831 [details] [review] [patch] Fixes the bugs This new one has the changes on gst/realmedia/rmdemux.c that Tim suggested
Thanks, looks much better :) Committed to CVS HEAD: 2006-10-16 Tim-Philipp Müller <tim at centricular dot net> Patch by: Josep Torra Valles <josep at fluendo com> * gst/iec958/ac3_padder.c: (ac3p_init): * gst/mpegstream/gstmpegparse.c: * gst/realmedia/rmdemux.c: (gst_rmdemux_parse__rmf), (gst_rmdemux_parse_prop), (gst_rmdemux_parse_mdpr), (gst_rmdemux_parse_indx), (gst_rmdemux_parse_indx_data), (gst_rmdemux_parse_data), (gst_rmdemux_parse_cont), (gst_rmdemux_parse_packet): Misc. fixes for problems discovered by Forte (different return types in function declaration and definition, pointer arithmetics with void pointers). Fixes #362639.