GNOME Bugzilla – Bug 362626
Fixes compiling with forte: warning clean up (part 5)
Last modified: 2006-10-17 14:58:09 UTC
Please describe the problem: gst/nsf/fds_snd.c: cast required gst/nsf/mmc5_snd.c: cast required gst/nsf/nsf.c: cast required gst/nsf/vrc7_snd.c: cast required gst/nsf/vrcvisnd.c: cast required gst/qtdemux/qtdemux.c: a lot of arithmethics with void pointers and statment not reached at gst_qtdemux_handle_sink_event Steps to reproduce: Compile it with Forte Actual results: Expected results: Does this happen every time? Other information:
Created attachment 74818 [details] [review] [patch] Fixes the bugs
Looks good, but it would be great if you could do for qtdemux the same you did for rmdemux, ie. convert all those gpointer/void * function arguments to guint8 * instead of using casts everywhere. Same for variables used in functions, most of them can probably be changed over to guint8, I don't think there's a reason why they have to be void *.
Committed the non-qtdemux bits: 2006-10-17 Tim-Philipp Müller <tim at centricular dot net> Patch by: Josep Torra Valles <josep at fluendo com> * gst/nsf/fds_snd.c: * gst/nsf/mmc5_snd.c: * gst/nsf/nsf.c: * gst/nsf/vrc7_snd.c: * gst/nsf/vrcvisnd.c: Fix some things the Forte compiler warns about (#362626). I've also removed most void pointer bits from qtdemux, could you run Forte again over what's in CVS now?
Created attachment 74866 [details] [review] [patch] Fixes the bugs This new patch fixes the issues that Tim detected in the previous patch.
Thanks, committed: 2006-10-17 Tim-Philipp Müller <tim at centricular dot net> Patch by: Josep Torra Valles <josep at fluendo com> * gst/qtdemux/qtdemux.c: (gst_qtdemux_handle_sink_event), (next_entry_size), (qtdemux_inflate), (qtdemux_parse_moov), (qtdemux_parse_tree), (qtdemux_parse_trak), (qtdemux_tag_add_str), (qtdemux_tag_add_num), (qtdemux_tag_add_date), (qtdemux_tag_add_gnre): Make compile with Forte compiler, mostly don't do pointer arithmetic with void pointers (#362626). (I did some additional changes, so please confirm that I didn't mess up anything that breaks Forte again).