After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 362528 - replace the find dialog box with a find bar
replace the find dialog box with a find bar
Status: RESOLVED FIXED
Product: meld
Classification: Other
Component: filediff
git master
Other All
: Normal enhancement
: ---
Assigned To: Stephen Kennedy
Stephen Kennedy
Depends on:
Blocks:
 
 
Reported: 2006-10-16 06:19 UTC by Tony Chang
Modified: 2013-03-29 04:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove find dialog and add a findbar (19.84 KB, patch)
2006-10-16 06:23 UTC, Tony Chang
none Details | Review

Description Tony Chang 2006-10-16 06:19:49 UTC
This is an idea for experimentation of a different UI for finding text in the diff view.  I prefer a find bar to appear at the bottom of the existing window rather than a new window (like what you get in Firefox) because you don't have to manage an extra window.
Comment 1 Tony Chang 2006-10-16 06:23:33 UTC
Created attachment 74780 [details] [review]
remove find dialog and add a findbar

This is a first cut to give an idea of how a find bar might work.  There's a problem that it doesn't expose the find options (word, case, regex, wrap).  I'm not sure what the appropriate UI for that is.

Also, I haven't used glade before but when I tried to edit the existing file, it seemed to generate different code so I just edited it by hand.  Not sure if that's ok.
Comment 2 Stephen Kennedy 2006-10-21 11:50:24 UTC
There's some code on the (failed) experimental cvs branch "branch-0_9" which does this and more IIRC.
Comment 3 Stephen Kennedy 2009-03-15 19:56:56 UTC
I've added code in svn for a findbar which has all the current options plus I added replace support at the same time.
Comment 4 Stephen Kennedy 2009-03-21 16:10:20 UTC
Actually there are still a few items to make this slick:

Remove popup dialogs - use a different notification of errors.
  Status label? Web-like tooltip popup?
Implement find previous
Implement replace all
Use history entry
Prefill entries with selected text, etc
Comment 5 Kai Willadsen 2013-03-29 04:15:08 UTC
Not sure why this is still open. This is basically all done, and any additional fixes should just be filed as new bugs.