GNOME Bugzilla – Bug 362202
[patch] A replacement of examples/vorbisplay.py for 0.10
Last modified: 2006-10-20 09:48:11 UTC
examples/vorbisplay.py should be removed, ported, or replaced as it doesn't run under gstreamer0.10. Below I have a proposed replacement. Aside from the file name and that they both play an ogg/vorbis file, my replacement doesn't have anything in common with the original, so I put my name in the copyright, as I see it as a replacement rather than a derivative. If anyone has a problem with this, I'd be happy to change this. I've submitted it as a patch in case that is easiest to commit, and also as a bare file as to be easier to review. Considering the number of great examples already included, I'm not certain this is a terribly important example anyway, so simply removing examples/vorbisplay.py is fine with me.
Created attachment 74701 [details] [review] Patch replaces examples/vorbisplay.py with alternative that runs under 0.10
Created attachment 74702 [details] vorbisplay.py, bare file for easier review
Created attachment 74821 [details] [review] Patch replaces examples/vorbisplay.py with alternative that runs under 0.10 adds missing gobject.threads_init()
Created attachment 74822 [details] vorbisplay.py, bare file for easier review adds missing gobject.threads_init()
99% of that is the same code as in decodebin.py (bug #362183)
2006-10-20 Jason Gerard DeRose <jderose@jasonderose.org> reviewed by: Edward Hervey <edward@fluendo.com> * examples/decodebin.py: * examples/gst123: * examples/vorbisplay.py: Removed gst123 and vorbisplay examples which weren't working with 0.10, and replaced them with decodebin.py Closes #362183 and #362202