After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 362120 - Query reset after removing images
Query reset after removing images
Status: RESOLVED FIXED
Product: f-spot
Classification: Other
Component: Browsing
0.2.1
Other All
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
: 373070 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-14 10:59 UTC by Andrew Mitchell
Modified: 2006-11-10 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Here's the proper fix (2.64 KB, patch)
2006-11-10 13:56 UTC, Stephane Delcroix
committed Details | Review

Description Andrew Mitchell 2006-10-14 10:59:32 UTC
Please describe the problem:
Forwarding from https://launchpad.net/distros/ubuntu/+source/f-spot/+bug/66077 and confirmed to exist in 0.2.2 on IRC

"When I am working on my new (thus untagged) photo's, and deleting these, f-spot goes back to the 'total' gallery of all photo's, instead of staying with the untagged ones. This is very anoying, for everytime I delete photo's from this section, I have to search again for untagged photo's.

VERY anooying bug this is."

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Larry Ewing 2006-10-15 20:57:18 UTC
probably happens because the untagged state isn't persisting properly.  I'll try to look into it soon.
Comment 2 Stephane Delcroix 2006-11-09 20:27:37 UTC
*** Bug 373070 has been marked as a duplicate of this bug. ***
Comment 3 Stephane Delcroix 2006-11-09 20:29:04 UTC
Changing title...
Comment 4 Stephane Delcroix 2006-11-10 11:29:10 UTC
This code snippet solve this bug

diff -r1.325 MainWindow.cs
2569c2569,2574
<               query.Tags = null;
---
>               if (query.Untagged) {
>                       query.Tags = null;
>                       query.Untagged = true;
>               } else
>                       query.Tags = null;
>

but I'll look further, I'm not sure that's the better way to fix that... 
Comment 5 Stephane Delcroix 2006-11-10 13:56:00 UTC
Created attachment 76327 [details] [review]
Here's the proper fix

That's the right way to fix it (and probably other strange things with queries in the future)