After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 361639 - MPA payloader's payload number is incorrect
MPA payloader's payload number is incorrect
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-12 07:48 UTC by Ville Syrjala
Modified: 2006-10-18 17:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix MPA payloader's payload number (773 bytes, patch)
2006-10-12 07:49 UTC, Ville Syrjala 		needs-work Details | Review
Fix RTP payload numbers (3.68 KB, patch)
2006-10-18 11:18 UTC, Ville Syrjala 		committed Details | Review

Description Ville Syrjala 2006-10-12 07:48:55 UTC 
MPA payloader's caps specify the payload number as dynamic. It should be 14.
Comment 1 Ville Syrjala 2006-10-12 07:49:35 UTC 
Created attachment 74545 [details] [review]
Fix MPA payloader's payload number
Comment 2 Wim Taymans 2006-10-13 09:34:19 UTC 
It can be dynamic as well. Perhaps a better patch would be to have a caps with 14 and one with dynamic params.
Comment 3 Ville Syrjala 2006-10-13 11:49:35 UTC 
I can make a new patch. Do you want to add support for dynamic payload number to all rtp elements that currently use a static number?
Comment 4 Wim Taymans 2006-10-13 13:33:20 UTC 
That would be nice, yes.
Comment 5 Ville Syrjala 2006-10-18 11:18:08 UTC 
Created attachment 74936 [details] [review]
Fix RTP payload numbers

Static+dynamic payload numbers for RTP payloaders except L16 because it doesn't even get built.
Comment 6 Wim Taymans 2006-10-18 17:06:43 UTC 
Thanks!


        Patch by: Ville Syrjala <ville dot syrjala at movial dot fi>

        * gst/rtp/gstrtpgsmpay.c:
        * gst/rtp/gstrtph263pay.c:
        * gst/rtp/gstrtpmpapay.c:
        * gst/rtp/gstrtppcmapay.c: (gst_rtp_pcma_pay_flush),
        (gst_rtp_pcma_pay_handle_buffer):
        * gst/rtp/gstrtppcmupay.c: (gst_rtp_pcmu_pay_flush):
        Add static payload numbers in addition to the dynamic ones.
        Fixes #361639.