After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 361634 - sink->ringbuffer NULL in BaseAudioSink's setcaps()
sink->ringbuffer NULL in BaseAudioSink's setcaps()
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-12 07:31 UTC by Ville Syrjala
Modified: 2006-10-13 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check if sink->ringbuffer is NULL (841 bytes, patch)
2006-10-12 07:33 UTC, Ville Syrjala 		committed Details | Review

Description Ville Syrjala 2006-10-12 07:31:09 UTC 
When switching the audio sink to a pipeline BaseAudioSink's setcaps() was called with NULL sink->ringbuffer. Adding a NULL check prevents the segfault, but I'm not sure if that is the proper fix, or even if the real bug is actually somewhere else.
Comment 1 Ville Syrjala 2006-10-12 07:33:23 UTC 
Created attachment 74542 [details] [review]
Check if sink->ringbuffer is NULL

Return early from setcaps() if sink->ringbuffer is NULL.
Comment 2 Wim Taymans 2006-10-13 09:31:42 UTC 
The real bug is not in baseaudiosink but due to Bug #339326. Will apply patch for now until the real issue is fixed.
Comment 3 Wim Taymans 2006-10-13 14:15:41 UTC 
        * gst-libs/gst/audio/gstbaseaudiosink.c:
        (gst_base_audio_sink_setcaps):
        Don't crash when ringbuffer is not yet created.
        Patch by: Ville Syrjala <ville dot syrjala at movial dot fi>
        Fixes #361634.