After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 361378 - we shouldn't use GOSSIP_ACCOUNT_TYPE_TELEPATHY
we shouldn't use GOSSIP_ACCOUNT_TYPE_TELEPATHY
Status: RESOLVED FIXED
Product: gossip
Classification: Deprecated
Component: Telepathy
0.17
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-11 08:36 UTC by Xavier Claessens
Modified: 2006-10-12 00:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (5.45 KB, patch)
2006-10-11 10:21 UTC, Xavier Claessens 		committed Details | Review

Description Xavier Claessens 2006-10-11 08:36:08 UTC 
By using GOSSIP_ACCOUNT_TYPE_TELEPATHY we loose the useful information of which IM protocol is used. My opinion is that if gossip is compiled with telepathy we can always assume that the GossipProtocol for all accounts is telepathy, so it's useless to set it has type for GossipAccount.

I'm working on this.
Comment 1 Xavier Claessens 2006-10-11 10:21:26 UTC 
Created attachment 74474 [details] [review]
proposed patch

This patch is for TELEPATHY branch. Now that we use real type, for gabble accounts we uses gossip-account-widget-jabber which needed a little fix to enable "ignore-ssl-errors" that was already discussed but dropped in last GossipAccount rework.
Comment 2 Eitan Isaacson 2006-10-12 00:23:29 UTC 
It compiled! Lovely!

Just getting the protocol name might not be good enough in the account setup widget case. Tomorrow gabble might get rid of a parameter, or might add one, and it will break Gossip. If one parameter is off, we should just give the generic widget.

...Something to think about.