Created attachment 74449 [details] [review]
proposed patch

This reverse the workaround in gossip_account_param_get, adds needed gossip_account_has_param proposed for HEAD in bug #361278 and use it to not assume "resource" parameter exists.

What is the plan with this? I don't want telepathy code outside the protocols dir...

Also, this needs redoing since the has_param patch has been applied.

It's not protocol-specific, the API needs to give a way of knowing if an account has a certain parameter or not.

Ooops, wrong bug :)

;) Yea, I'm talking about the #ifdef TELEPATHY-thing.

I think Xavier was a bit too vague, I didn't look at the code yet, but it seems like there are over 150 mentions of "resource" outside of the jabber protocol dir. If we want true seperation between protocols and everything else we should minimize the assumption that there is such a thing as resources in gossip. And concentrate all of the resource logic in the jabber dir.

I'm -only- talking about the ifdef in the patch attached here that puts telepathy code outside the telepathy dir.

Sorry I set the wrong component. This patch is for TELEPATHY branch and fix protocols/telepathy/gossip-telepathy.c. I checked other places and everywhere (outside protocols/jabber) it doesn't assume the resource exists !

Oh, Oops again :)
This bug should be filed under telepathy, thats a patch we dicussed earlier, I'll commit it.

Aah, sorry for the confusion then :)

Thanks Xavier for a lovely patch.

maybe I'm missing something but the patch is not committed into TELEPATHY branch...

I have committed this for you.