After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 361077 - Copying songs from DAAP to iPod doesn't work
Copying songs from DAAP to iPod doesn't work
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: DAAP
0.9.6
Other All
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-10 08:08 UTC by Christophe Dehais
Modified: 2006-11-19 09:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rhythmbox -d output when dragging an album (12 songs) from daap to ipod (6.44 KB, text/plain)
2006-10-15 11:34 UTC, Christophe Dehais 		  Details
potential patch (1.18 KB, patch)
2006-10-31 11:23 UTC, James "Doc" Livingston 		none Details | Review
another patch (6.04 KB, patch)
2006-11-12 05:17 UTC, Jonathan Matthew 		committed Details | Review

Description Christophe Dehais 2006-10-10 08:08:27 UTC 
Please describe the problem:
Dragging a (or a bunch of) remotely song(s) from a DAAP share to the iPod doesn't actually copy the song.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?
yes

Other information:
Comment 1 Alex Lancaster 2006-10-13 08:56:32 UTC 
Can you attach the log of "rhythmbox -d" showing what happens when you attempt the copy?
Comment 2 Christophe Dehais 2006-10-15 11:34:30 UTC 
Created attachment 74751 [details]
rhythmbox -d output when dragging an album (12 songs) from daap to ipod

Attached the output of 'rhythmbox -d' when dragging an album (12 songs) from daap to the ipod.
Comment 3 Jonathan Matthew 2006-10-21 23:20:26 UTC 
This happens because the target source calls gnome_vfs_uri_new with the source URI (in ipod_get_filename_for_uri), and gnome-vfs doesn't understand daap:// URIs.  I'm not sure exactly what we should do about this, but avoiding gnome_vfs_uri_new is probably a good idea.
Comment 4 James "Doc" Livingston 2006-10-31 11:23:42 UTC 
Created attachment 75717 [details] [review]
potential patch

This basically reimplements the GnomeVFSUri function, but for arbitrary char* uris. I haven't done a huge amount of testing, but I think it is right.
Comment 5 Jonathan Matthew 2006-11-12 05:17:19 UTC 
Created attachment 76419 [details] [review]
another patch

moves rb_uri_extract_short_name to rb-file-helpers.c, adds some unit tests for it,  and teaches it about query strings.
Comment 6 James "Doc" Livingston 2006-11-12 05:26:59 UTC 
Looks good to me.
Comment 7 Jonathan Matthew 2006-11-19 09:19:27 UTC 
OK, committed.