GNOME Bugzilla – Bug 360946
Migrate from GnomeAbout to GtkAboutDialog
Last modified: 2013-09-10 13:50:42 UTC
Evolution is still using the deprecated GnomeAbout widget from libgnomeui, and should migrate to the newer GtkAboutDialog (available since GTK+ 2.6). I also noticed that the code is trying to load "evolution-1.5.png" for the logo image on the About dialog, which is why Evolution currently displays the generic GNOME footprint.
Created attachment 74367 [details] [review] Proposed patch This patch does a few things: - Uses GtkAboutDialog instead of GnomeAbout. - Adds a link to the Evolution website [1] on the About dialog. - Uses the correct logo filename (generated by the build tools). - Polishes some autoconf/automake details related to the logo file. [1] http://www.gnome.org/projects/evolution/
three cheers! :-)
This is a proposed GNOME Goal: http://live.gnome.org/GnomeGoals/AboutDialog
This bug requires clarification of Evolution's library requirements. Please see bug #380534.
Created attachment 77781 [details] [review] Revised patch Here's a much cleaner patch: - Uses GtkAboutDialog instead of GnomeAbout. - Adds a link to the Evolution website [1] on the About dialog. - Specifies the logo by name ("evolution") instead of loading a pixbuf. - Evolution windows default to the "evolution" icon instead of "stock_mail". - No autoconf/automake changes. - Satisfies GNOME Goal #2.1: Install theme-friendly icons [1] [1] http://live.gnome.org/GnomeGoals/AppIcon
Also, the old Ximian logo (art/evolution.png) is now obsolete. Maybe we should stop shipping it?
Evolution should be shipping the "evolution" icons itself (bug #350253). I'm making this bug depend on it.
Ping: this would add some nice polish to Evo 2.10.
Committed to HEAD.