After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360658 - Impress, OpenDocument and cleaning up document factory
Impress, OpenDocument and cleaning up document factory
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-08 14:42 UTC by Wouter Bolsterlee (uws)
Modified: 2006-10-08 14:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed fix (2.67 KB, patch)
2006-10-08 14:44 UTC, Wouter Bolsterlee (uws) 		none Details | Review

Description Wouter Bolsterlee (uws) 2006-10-08 14:42:35 UTC 
The file backend/ev-document-factory.c conditionally includes some backend files depending on configure flags, while others are included inconditionally.

Also, the impress backend does not accept OpenDocument presentations. I've added the MIME-types to the files involved to get preliminary support. Lots of warnings and rendering doesn't look good at all, but the Impress backend is experimental anyway, right?
Comment 1 Wouter Bolsterlee (uws) 2006-10-08 14:44:19 UTC 
Created attachment 74295 [details] [review]
Proposed fix

Please review before committing ;)
Comment 2 Wouter Bolsterlee (uws) 2006-10-08 14:52:28 UTC 
Reviewed by nsh:
< nsh> y, please commit

2006-10-08  Wouter Bolsterlee  <wbolster@gnome.org>

        * backend/ev-document-factory.c:
        * configure.ac:
        Assigned OpenDocument presenation MIME type to the
        Impress backend. Added some missing (but harmless)
        #ifdefs in the document factory as well to make things
        consistent again. Fixes bug #360658.