After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360552 - [riff] [avi] extracts non-UTF8 metadata
[riff] [avi] extracts non-UTF8 metadata
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: High critical
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 379477 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-08 04:30 UTC by Young-Ho Cha
Modified: 2006-11-27 11:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16



Description Young-Ho Cha 2006-10-08 04:30:50 UTC
Version: 2.16.2

What were you doing when the application crashed?



Distribution: Ubuntu 6.10 (edgy)
Gnome Release: 2.16.1 2006-10-02 (Ubuntu)
BugBuddy Version: 2.16.0
Comment 1 Young-Ho Cha 2006-10-08 04:36:42 UTC
This is gdb backtrace log.

  • #0 IA__g_markup_escape_text
    at gmarkup.c line 1903
  • #1 totem_action_toggle_controls
  • #2 totem_action_toggle_controls
  • #3 IA__g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 77
  • #4 IA__g_closure_invoke
    at gclosure.c line 490
  • #5 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #6 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #7 IA__g_signal_emit
    at gsignal.c line 2243
  • #8 totem_playlist_set_title
  • #9 totem_action_pause
  • #10 IA__g_cclosure_marshal_VOID__VOID
    at gmarshal.c line 77
  • #11 IA__g_closure_invoke
    at gclosure.c line 490
  • #12 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #13 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #14 IA__g_signal_emit
    at gsignal.c line 2243
  • #15 bacon_video_widget_set_video_property
  • #16 marshal_VOID__MINIOBJECT
    at gstbus.c line 159
  • #17 IA__g_closure_invoke
    at gclosure.c line 490
  • #18 signal_emit_unlocked_R
    at gsignal.c line 2440
  • #19 IA__g_signal_emit_valist
    at gsignal.c line 2199
  • #20 IA__g_signal_emit
    at gsignal.c line 2243
  • #21 gst_bus_async_signal_func
    at gstbus.c line 901
  • #22 gst_bus_source_dispatch
    at gstbus.c line 627
  • #23 IA__g_main_context_dispatch
    at gmain.c line 2045
  • #24 g_main_context_iterate
    at gmain.c line 2677
  • #25 IA__g_main_loop_run
    at gmain.c line 2881
  • #26 gst_bus_poll
    at gstbus.c line 861
  • #27 bacon_video_widget_error_quark
  • #28 bacon_video_widget_error_quark
  • #29 bacon_video_widget_open_with_subtitle
  • #30 totem_action_set_mrl_with_warning
  • #31 totem_action_set_mrl
  • #32 totem_action_set_mrl_and_play
  • #33 totem_action_play_pause
  • #34 main

Comment 2 Young-Ho Cha 2006-10-08 04:39:28 UTC
This is Movie clip info via mplayer output. (encoding charset is shift-jis)

VIDEO:  [DX50]  640x440  24bpp  23.976 fps  1373.6 kbps (167.7 kbyte/s)
Clip info:
 Source: MBS
 Name: コードギアス 反逆のルルーシュ 第01話 「魔神が生まれた日」
 Genre: anime
 Software: VirtualDubMod 1.5.10.2 (build 2542/release)
 Comments: 映像:DivX640 qt=2.8 i-link TScap
音声:Lame mp3 48kHz 160kbps
 Artist: aaLPbRVQ8B
Comment 3 Bastien Nocera 2006-10-08 12:54:42 UTC
Could you attach the first couple of megabytes from the video, so that I can reproduce the problem myself?
Comment 4 Young-Ho Cha 2006-10-08 23:22:49 UTC
You can get a movie clip for reproducing this problem.

http://ftp.mizi.com/~ganadist/cg_sample.avi

Comment 5 LAVIE 2006-10-18 08:48:37 UTC
http://ftp.mizi.com/~ganadist/cg_sample.avi

it play good
Comment 6 Bastien Nocera 2006-10-23 15:31:07 UTC
It really doesn't like the title:
./totem-video-indexer cg_sample.avi 

(<unknown>:6046): GStreamer-WARNING **: Trying to set string field 'title' on structure, but string is not valid UTF-8. Please file a bug.

(<unknown>:6046): GStreamer-WARNING **: Trying to set string field 'comment' on structure, but string is not valid UTF-8. Please file a bug.

(<unknown>:6046): GStreamer-WARNING **: Trying to set string field 'title' on structure, but string is not valid UTF-8. Please file a bug.

(<unknown>:6046): GStreamer-WARNING **: Trying to set string field 'comment' on structure, but string is not valid UTF-8. Please file a bug.
TOTEM_INFO_TITLE=�R�[�h�M�A�X ���t�̃����[�V�� ��01�b �u���_�����܂ꂽ�
TOTEM_INFO_ARTIST=aaLPbRVQ8B
TOTEM_INFO_DURATION=19
TOTEM_INFO_HAS_VIDEO=True
TOTEM_INFO_VIDEO_CODEC=DivX MPEG-4 Version 5
TOTEM_INFO_HAS_AUDIO=True
TOTEM_INFO_AUDIO_CODEC=MPEG-1 layer 3

Eek.
Comment 7 Tim-Philipp Müller 2006-10-25 15:25:00 UTC
Committed a workaround to HEAD and 2.16 branch:

 2006-10-25  Tim-Philipp Müller  <tim at centricular dot net>

        * src/backend/bacon-video-widget-gst-0.10.c:
        (bacon_video_widget_get_metadata_string):
          Make extra sure we only return valid UTF-8 strings as metadata,
          since g_markup_escape_text() tends to just crash if the input is
          not valid UTF-8 (see #360552).

Ultimately needs fixing in GStreamer => moving
Comment 8 Tim-Philipp Müller 2006-10-26 10:51:07 UTC
 2006-10-26  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/gststructure.c: (gst_structure_id_set_value):
          If someone tries to set a non-UTF8 string field on a structure,
          don't just print a warning, but also ignore the request and do
          not change/add that field to the structure.

        * tests/check/gst/gsttag.c: (GST_START_TEST), (gst_tag_suite):
          Test for the above.


 2006-10-26  Tim-Philipp Müller  <tim at centricular dot net>

        * gst-libs/gst/riff/riff-read.c: (freeform_string_to_utf8),
        (gst_riff_parse_info):
          If strings in INFO chunk are not UTF-8, do something similar to
          what we do for ID3v1 tags: check a number of environment variables
          (GST_AVI_TAG_ENCODING, GST_RIFF_TAG_ENCODING, GST_TAG_ENCODING) for
          character sets to try, otherwise try the current locale and/or fall
          back on ISO-8859-1. Fixes #360552.


 $ GST_TAG_ENCODING=shift-jis gst-launch-0.10 playbin uri=file:///home/tim//cg_sample.avi -t

FOUND TAG      : found by element "avidemux0".
            ISRC: MBS
           title: コードギアス 反逆のルルーシュ 第01話 「魔神が生まれた日」
           genre: anime
         encoder: VirtualDubMod 1.5.10.2 (build 2542/release)
         comment: 映像:DivX640 qt=2.8 i-link TScap
音声:Lame mp3 48kHz 160kbps
          artist: aaLPbRVQ8B

Comment 9 Bastien Nocera 2006-11-27 11:58:45 UTC
*** Bug 379477 has been marked as a duplicate of this bug. ***