GNOME Bugzilla – Bug 360507
'Muted' doesn't display any special icon anymore
Last modified: 2010-01-24 01:07:05 UTC
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/gnome-applets/+bug/64539 "Hi, Since upgrading to edgy beta from dapper, the mixer applet (volume applet 2.16.1) doesn't display any special icon when I mute the master volume. It used to display a loudspeaker icon with a red line over it. I have gnome-applets 2.16.1-0ubuntu2. Thanks! ... http://librarian.launchpad.net/4703541/volume-applet.jpg screenshot volume applet I can confirm this on Edgy Beta,up to date."
Created attachment 74378 [details] [review] show the mute icon if the mixer is muted Here's a small patch that fixes the bug for me. It should be pretty obvious what it does: when the mixer is muted, ignore the volume setting and show the "muted" icon.
http://cvs.gnome.org/viewcvs/gnome-applets/mixer/applet.c?r1=1.53&r2=1.54 Davyd, can you please explain why the above patch, which clearly breaks things and shouldn't do any such thing, was applied? Or maybe Matthias (I don't know his bugzilla ID) can explain that patch? This really isn't a good idea, things such as volume control should be hellishly stable on a desktop, it may be a good idea to CC me on bugs before applying patches like those...
The bug this came from is bug #354986. It seemed to fix a real issue and use less memory in the process. I have to assume you're already receiving bug reports for software that you're interested in. I now see where it is broken. I didn't test the hardware mute option, so I never discovered it. Perhaps, in order to mitigate this in the future, we should start writing a testing manual that covers each of the applets and a series of tests that should be conducted on it.
I like the testsuite idea. As for bug report reading, it changes with study load...
Yes, sorry for breaking the mute icon. I later fixed my patch, but forgot to put it here...
Created attachment 75706 [details] [review] current FC6 patch against 2.16.0.1
I still don't see the mute icon in rawhide. Are you sure this patch works correctly?
Here is a patch I needed to make the mute icon work in 2.16.1
Created attachment 76715 [details] [review] patch
Please apply ASAP, let's try to have this ready in 2.16.2 (and hope all distros update accordingly).
2006-11-17 Matthias Clasen <mclasen@redhat.com> * mixer/applet.c: Fix mute icon. (#360507)