GNOME Bugzilla – Bug 360495
Errors in Java/Verilog syntax files
Last modified: 2006-10-14 11:06:42 UTC
Verilog: - missing "begin" in keywords (corresponds to already-present "end") Java: - "enum" Java 1.5 type not present - "assert" keyword not present - "finally" in Modifiers list, not the Flow list (no visual difference) - "const"/"gotol" [sic] in Modifiers list (both reserved keywords) - "strictfp" modifier (of classes, interfaces, methods) not present - "true"/"false" not present as literals (and "null" not grouped as literal)
Created attachment 74249 [details] [review] Patch for all issues described The patch was made against trunk, for what it's worth. I suspect it applies to older versions of GNOME as well.
Thank you very much for the patch. The patch against java.lang introduces new translatable strings so we cannot commit it for gsv 1.8. Could you please refactor your patch avoiding adding new keyword-lists?
Created attachment 74328 [details] [review] Addresses comments (In reply to comment #2) > The patch against java.lang introduces new translatable strings so we cannot > commit it for gsv 1.8. Is this an artifact of the source organization? Language keywords and syntax really shouldn't be localizable (unless there exist real-world languages with fully localized syntax -- please enlighten me if such languages exist!). I looked through the de.po file to check whether keywords were localized, and it looks like the _names are localized. However, note that the "new" _names I used in java.lang are already used in javascript.lang, so they're not "new strings". Unless "#:" lines in PO files have semantic meaning in the final localization (web searches indicate they have none, and if they did I'd be surprised if there weren't tools to auto-fix them), translators shouldn't have any extra work to perform. What am I missing here? (To be absolutely clear, when it comes down to it whether or not this makes 1.8 doesn't really matter to me if I can change the files locally for the same effect. Everyone else, tho, has to be able to find this bug or guess that the language definitions are in uncompiled code to make the change.) > Could you please refactor your patch avoiding adding new keyword-lists? I removed the literals section from java.lang since it's mostly just there to follow the example of the excellently-formatted javascript.lang, but I don't see how you can get rid of the reserved keywords keyword-list -- nothing else with the same styling exists in java.lang. For now I assume this is what you wanted.
The only localized part are the _names. Since as you say the string you use is already present in javascript.lang, we can commit the patch without breaking the string freeze. In fact I just committed it :) Thanks a lot for the patch! 2006-10-14 Paolo Borelli <pborelli@katamail.com> * gtksourceview/language-specs/java.lang: * gtksourceview/language-specs/verilog.lang: Add some missing keywords. Bug #360495, patch by Jeff Walden.