After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360479 - patch needed for Solaris support
patch needed for Solaris support
Status: RESOLVED FIXED
Product: dogtail
Classification: Deprecated
Component: Framework
CVS HEAD
Other opensolaris
: Normal normal
: ---
Assigned To: Dogtail Maintainers
Dogtail Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-07 19:51 UTC by Brian Cameron
Modified: 2006-10-10 21:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to allow dogtail to work on Solaris (1.28 KB, patch)
2006-10-07 19:51 UTC, Brian Cameron 		none Details | Review
updated patch (1.45 KB, patch)
2006-10-07 20:19 UTC, Brian Cameron 		committed Details | Review

Description Brian Cameron 2006-10-07 19:51:07 UTC 
Patch for dogtail to work on Solaris.
Comment 1 Brian Cameron 2006-10-07 19:51:44 UTC 
Created attachment 74244 [details] [review]
patch to allow dogtail to work on Solaris
Comment 2 Brian Cameron 2006-10-07 20:19:32 UTC 
Created attachment 74246 [details] [review]
updated patch


Please ignore previous patch.  This patch is the same, but has a useful comment.
Comment 3 Zack Cerza 2006-10-10 20:49:47 UTC 
Fixed in the development version. The fix will be available in the next major release. Thank you for your bug report.
Comment 4 Dave Malcolm 2006-10-10 21:16:15 UTC 
I'm a little wary of the patch as it stands:
if "/etc/release" exists, but the regex on the next line doesn't match the first line of it, then distro is None, and no exception is thrown - is this a problem?
Comment 5 Zack Cerza 2006-10-10 21:41:02 UTC 
Ah, good point. If you were on some unknown, non-Solaris distro, you'd see:

Traceback (most recent call last):

+ Trace 75697

  • File "<string>", line 1 in ?
  • File "dogtail/distro.py", line 329 in ? 
    if re.match (".*Solaris", open ("/etc/release").readlines()[0]):
IndexError: list index out of range 

I fixed it so the elif clause looks like:

elif os.path.exists ("/etc/release") and \
        re.match (".*Solaris", open ("/etc/release").readline()):