After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360347 - the apply button should be a close button
the apply button should be a close button
Status: RESOLVED NOTABUG
Product: gnome-control-center
Classification: Core
Component: Background
2.16.x
Other All
: Normal trivial
: ---
Assigned To: Rodney Dawes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-07 09:57 UTC by pavel
Modified: 2007-01-08 16:43 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Just change the button (3.80 KB, patch)
2006-10-10 12:27 UTC, Jonh Wendell 		rejected Details | Review

Description pavel 2006-10-07 09:57:22 UTC 
Please describe the problem:
all the other gnome applets have a help and a close button, while gnome-background-properties has an help and an Finish button.
This is probably a leftover from the times when you were experimenting with click-to-apply but since instant-apply is back, I think this should be a stock close button again.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Jonh Wendell 2006-10-10 12:27:23 UTC 
Created attachment 74401 [details] [review]
Just change the button

Trivial patch.
Comment 2 Rodrigo Moya 2006-10-10 14:34:33 UTC 
This looks good to me, Rodney?
Comment 3 Rodney Dawes 2006-10-10 15:54:18 UTC 
No. It is not changing back to close. The plan was to change all the other capplets in 2.16 to Finish as well, but we missed the UI freeze deadline. We can change them all to something other than Close or Finish for 2.18 if we really must, but it MUST be an affirmitive string, and useful icon. The [x Close] icon is not affirmitive, and the icon isn't informative to the user.
Comment 4 pavel 2006-10-11 19:27:33 UTC 
could you perhaps explain the reasoning behind this? (or point to the document)
since I would prefer a neutral button labeling on a instant-apply dialog.
If it is affirmative it implies that the user has to click it to apply or that some invisible changes will be applied once the user clicks it - even if he returned to initial selection.
Comment 5 Rodney Dawes 2006-10-11 19:48:47 UTC 
If it's not affirmitive, then it implies to the user that their changes won't be saved. It also means that the button in the lower right corner is not the affirmitive button. I have explained this multiple times on the mailing list. Feel free to read through the archives. I believe it came up on the usability and desktop-devel lists.