After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360210 - Some plugins don't compile after a make distclean
Some plugins don't compile after a make distclean
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: Internet Radio
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-06 16:16 UTC by Ryan P Skadberg
Modified: 2006-10-06 18:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix iRadio issue (492 bytes, patch)
2006-10-06 16:59 UTC, Ryan P Skadberg 		none Details | Review
Patch that fixes both iradio and audioscrobbler issues (978 bytes, patch)
2006-10-06 17:13 UTC, Ryan P Skadberg 		none Details | Review
patch (1.10 KB, patch)
2006-10-06 17:40 UTC, William Jon McCann 		committed Details | Review

Description Ryan P Skadberg 2006-10-06 16:16:19 UTC 
iradio-ui.xml is in plugin_DATA and CLEANFILES is set to plugin_DATA.  So when make distclean is done, the xml file is erased.

Seems that one of 2  things need to happen:

a) the .xml file needs to be switched to a .in file and generated
b) CLEANFILES needs to be set to it's own set of files and not include the .xml file
Comment 1 Ryan P Skadberg 2006-10-06 16:59:24 UTC 
Created attachment 74158 [details] [review]
Patch to fix iRadio issue

This does the 2nd option for iradio.
Comment 2 Ryan P Skadberg 2006-10-06 17:00:35 UTC 
Crap!  Same problem in audioscrobbler.  We erase the as-powered.png when cleaning.
Comment 3 Ryan P Skadberg 2006-10-06 17:13:31 UTC 
Created attachment 74161 [details] [review]
Patch that fixes both iradio and audioscrobbler issues

OK, after this patch, things compile.
Comment 4 William Jon McCann 2006-10-06 17:40:31 UTC 
Created attachment 74167 [details] [review]
patch

This patch does it a bit differently by using the somewhat conventional BUILT_SOURCES variable to make it clean what is generated.  We should probably do the same for the other plugins.
Comment 5 William Jon McCann 2006-10-06 18:30:09 UTC 
Should be fixed in CVS.  Thanks.