After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 360171 - Warnings generated from incompatible signedness assignments in theora plugin
Warnings generated from incompatible signedness assignments in theora plugin
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-06 14:00 UTC by Ben Gamari
Modified: 2006-10-10 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch (1.13 KB, patch)
2006-10-06 14:02 UTC, Ben Gamari 		rejected Details | Review

Description Ben Gamari 2006-10-06 14:00:29 UTC 
Compiling with -Werror fails due to assignments of incompatible signedness in theoradec.c and theoraenc.c. Attached is a patch which makes the appropriate (correct?) casts. Should this be filed upstream?
Comment 1 Ben Gamari 2006-10-06 14:02:09 UTC 
Created attachment 74133 [details] [review]
Patch

I just kind of guessed at the casts. They make sense although perhaps the types of some of the locals should be changed. It looks pretty darn ugly at times.
Comment 2 Wim Taymans 2006-10-10 10:39:56 UTC 
This changed since -alpha4, please upgrade.