After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359912 - Key search in "Open with" -> "Other application" Applications List is searching by binary name instead app title
Key search in "Open with" -> "Other application" Applications List is searchi...
Status: RESOLVED FIXED
Product: eel
Classification: Deprecated
Component: general
2.19.x
Other All
: Normal normal
: ---
Assigned To: Christian Neumair
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-05 15:37 UTC by otto_rey
Modified: 2007-06-01 13:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.19/2.20


Attachments
Proposed patch, flavor A (889 bytes, patch)
2006-10-05 18:43 UTC, Christian Neumair
none Details | Review
Proposed patch, flavor B (2.89 KB, patch)
2006-10-05 18:47 UTC, Christian Neumair
committed Details | Review

Description otto_rey 2006-10-05 15:37:01 UTC
Please describe the problem:
The list of applications in "Open With" -> "Other application" show applications
titles. When try to search its find by binary name instead of app title.

Steps to reproduce:
1. Open Nautilus. Rigth-click on file, and choose "Open With" -> "Other application"
2. Try to find typing the application title. The list incorrecly find by binary
name. For example, if i start typing "Gestor de archivadores" the list goes to
any item. But if i type "file-roller" the list go to "Gestor de archivadores"
3. 


Actual results:
The list go to incorrect item

Expected results:
The list go to item that you start typing by app title.

Does this happen every time?
Yes, always.

Other information:
Comment 1 Christian Neumair 2006-10-05 18:33:07 UTC
Confirming, updating bug metadata. The issue seems to be that we have multiple string columns in the open with dialog tree view's model.
Comment 2 Christian Neumair 2006-10-05 18:41:47 UTC
Reassigning to eel.
Comment 3 Christian Neumair 2006-10-05 18:43:17 UTC
Created attachment 74082 [details] [review]
Proposed patch, flavor A

The attached patch sets the search column to the name column instead of the path (i.e. the "Exec") column.
Comment 4 Christian Neumair 2006-10-05 18:47:13 UTC
Created attachment 74084 [details] [review]
Proposed patch, flavor B

The attached patch implements a custom search function that will search in all columns, i.e. "name", "comment" and "path" (i.e. Exec).

The advantage is that you can find apps by its binary name and by its menu name.

The disadvantage is that you can't easily list all apps beginning with a particular letter, since most letters will match a comment or a binary name, at least it's sometimes not obvious why entering "file-roller" jumps to "Archive Manager" instead of "FooBarApp".

Maybe we could use this variant after removing the comment-related bits, after all the user usually won't know how the comment begins, but power users know the prefix of the binary name.
Comment 5 Christian Neumair 2006-10-05 18:50:09 UTC
Otto: One additional question: What file type wasn't associated that should have been mapped to file-roller? Let's file another bug report on the issue! :)
Comment 6 otto_rey 2006-10-05 21:14:50 UTC
Just an example ;) The first binary-name that comes to my mind :)
Comment 7 Christian Neumair 2006-10-06 08:10:44 UTC
So maybe you still inform us what association wasn't correct/existant? We're trying to make the MIME data as complete as possible so that you won't have to mess around with it, and we'll forward your griefs to the appropriate persons.
Comment 8 otto_rey 2006-10-09 22:54:55 UTC
Ummm... open .asp ( puajk :) ) with Quanta Plus... im going to open a bug with this...
Comment 9 Alexander Larsson 2006-10-18 12:07:36 UTC
I agree with approach B, but not matching on the comment. 
Please remove matching on the comment and commit.
Comment 10 Baptiste Mille-Mathias 2006-12-12 09:19:15 UTC
Hi Christian, 

Is there any news on this patch? (I don't want to offense you, just to poke you a little, perhaps a patch is lying on your hard drive :))

Thanks
Comment 11 Sebastien Bacher 2007-05-19 12:57:27 UTC
Ubuntu bug about that on https://bugs.launchpad.net/eel/+bug/112842, maybe the patch could be commited?
Comment 12 Christian Neumair 2007-06-01 13:07:53 UTC
"Proposed patch, flavor B" committed after removal of comment-related code.
Sorry that I didn't react earlier, but the bug noise is massive and I don't have time to read through all of it.