After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359707 - patch to fix important warning in launcher.c
patch to fix important warning in launcher.c
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-10-04 20:36 UTC by Tom Tromey
Modified: 2006-10-19 12:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to fix warning (699 bytes, patch)
2006-10-04 20:36 UTC, Tom Tromey 		accepted-commit_now Details | Review

Description Tom Tromey 2006-10-04 20:36:01 UTC 
In launcher.c:panel_launcher_delete(), the 'location' variable
is used uninitialized.  gcc warns about this; in this case the
warning indicates a real error.
I'll attach a fix shortly.
Comment 1 Tom Tromey 2006-10-04 20:36:37 UTC 
Created attachment 74023 [details] [review]
patch to fix warning
Comment 2 Vincent Untz 2006-10-08 13:03:43 UTC 
Oops, nice catch :-)

Do you have a cvs account to commit the patch? If yes, please go ahead!
Comment 3 Tom Tromey 2006-10-08 16:15:14 UTC 
I'm sure my account has long since expired.
Comment 4 JP Rosevear 2006-10-19 02:47:43 UTC 
Its important to commit this, it can cause evil things to happen removing a launcher from the panel
Comment 5 Tom Tromey 2006-10-19 04:24:02 UTC 
FWIW I'd be delighted to commit, but my account-reactivation
email has gone unanswered.  So, perhaps someone else should commit
instead.
Comment 6 JP Rosevear 2006-10-19 12:58:11 UTC 
Since it was just waiting on your commit privs and it was accepted, I committed it.