After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 359065 - reference documentation: stock icons not included
reference documentation: stock icons not included
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: reference documentation
2.10.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2006-10-02 18:07 UTC by Murray Cumming
Modified: 2008-02-19 02:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
refdocs_stock.patch (22.29 KB, patch)
2006-10-02 18:10 UTC, Murray Cumming 		none Details | Review

Description Murray Cumming 2006-10-02 18:07:59 UTC 
docs/reference/Makefile sets IMAGE_PATH so that doxygen can find and used the stock icon .png files. I think it tries to use them from the installed location, but I think that location has changed.

I also think that the directory structure in gtk+/gtk/stock-icons has changed, so this patch might be half of a solution.
Comment 1 Murray Cumming 2006-10-02 18:10:54 UTC 
Created attachment 73877 [details] [review]
refdocs_stock.patch
Comment 2 Jonathon Jongsma 2008-02-18 17:01:57 UTC 
I wonder if we shouldn't just use a svn:external property to fetch the gtk stock icons from GTK+ svn into our own tree and use them instead of trying to do some trickery to get them from a GTK+ checkout.  It seems like that would be more robust.  

Also, as far as I can tell, the GTK+ stock icons are never actually installed anywhere, I think they might actually be compiled into GTK+ somehow...
Comment 3 Jonathon Jongsma 2008-02-18 19:23:33 UTC 
OK, I've got a fix for this in my local tree.  It involves fetching the GTK+ stock items from svn into the gtkmm tree using svn:externals as I described above.  The one problem with this approach is that there are apparently some icons that are not unique but are symlinked to other names (e.g. media-next-ltr is symlinked to media-prev-rtl).  When I just fetch the stock items via svn:externals, we don't get the GTK+ build rules which create the symlinked versions.  So there are a few stock items that are missing.  Should I come up with a better approch or just commit it this way?
Comment 4 Jonathon Jongsma 2008-02-18 19:29:00 UTC 
btw, part of the issue with attachment #73877 [details] is that doxygen (at least the version that I have) can't seem to handle images that are in subdirectories of IMAGE_PATH.  So for example, if you set IMAGE_PATH to '../gtk+/gtk/stock-icons/', the following command won't work

@image html 48/foo-icon.png

instead you have to set IMAGE_PATH to the directory that directly contains the icon. So you'd need to set it to something like

IMAGE_PATH=../gtk+/.../48/ ../gtk+/.../24/ ../gtk+/.../16/
Comment 5 Jonathon Jongsma 2008-02-19 02:28:00 UTC 
OK, I committed this even though it's not perfect yet.  It should be easy to revert, so let me know if you have any concerns about it.