GNOME Bugzilla – Bug 358945
[Patch] Punctuation errors in preferences dialog
Last modified: 2009-08-15 18:40:50 UTC
A few small errors in the preferences dialog: * widget labels shouldn't have a full stop * there should be no space before a colon Attaching a patch.
Created attachment 73834 [details] [review] Patch changing the labels
Hmm, that will break a lot of translations. Can you supply patches for those too? If you have CVS access, feel free to commit this directly.
I don't know that much about translations, but when a string only changes slightly, doesn't it get marked as 'fuzzy' and the translation is still used? If it's just a matter of going through po files and removing the full stops there too, I can do that.
Looking at the msgfmt info page, it looks like --use-fuzzy is not the default. So yes, the source strings need to be updated in all the po files. Also the translated strings. Some of the po files have tidied up the formatting in the translations already!
Ouch... I didn't realize how many po files there are. Could you enable fuzzy? It strikes me that this is exactly the sort of circumstance it's meant for.
%grep fuzzy po/*.po | wc -l 261 Sorry, thats too many side effects. It strikes me that this kind of thing is not exactly rare, so there should be scripts to help. Know anybody on the i18n team?
Reply to Comment #4: By default msgfmt should mark those strings as fuzzy. And these fuzzied strings would not show at all, except on Solaris. Actually, what is the platform you're using? Reply to Comment #3 and Comment #6: Using script here can cause trouble for some languages. Indeed it would be fine for latin languages, but not for others. For example, Chinese use another punctuation mark for full stop or comma. It is better to leave that for translators, UNLESS the change is not related to normal sentences. If there will be a new release very soon, I'd suggest committing the patch after release, because translators would not have enough time to catch up. Otherwise it would be fine to commit the patch IMHO. As a final note, meld is not affected by any string freeze at all, as it is not included in basic GNOME desktop and library platform.
Can I commit this, Stephen?
Did you make any progress in fixing up the translations for latin languages? Go ahead and commit & resolve in any case.
Before I commit -- your changelog file seems to be the details of each release rather than a list of CVS commits. Should I add an entry to that, and if so, how and in what format? I've not made much headway with the translations. Once I've committed the glade file change, I'll try and do some of them.
Just write a good commit message. When making a release, I scan and summarize the output of cvs2cl into a more readable and user-relevant form.
Committed meldapp.glade I'll try and do a few of the latin po files, but I'm pretty busy with work on docs and gnome web.
I've made the change to bg.po and committed. Please could you check I've not broken anything? :)
it's up to i10n teams to update translations not for developers :) this bug should be closed if the patch is commited and the only remaining change to be made is update translations ... a mail to i18n mailinglist it's enough to call for translations usually a mail to i18n mailinglist a week (or as more weeks you can) before the release of a new release is the way you can at least have major languages up-to-date for the release day :)
So long ago I don't remember but from the comments it looks like I committed the main patch. So closing.