After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 358824 - Affect - misuse of term in Transform tools label.
Affect - misuse of term in Transform tools label.
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: User Interface
git master
Other All
: Normal minor
: ---
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2006-10-01 18:13 UTC by gg
Modified: 2006-10-03 19:34 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description gg 2006-10-01 18:13:22 UTC
The text label Affect is incorrect usage. It should be Effect.

The help hints read (example) "Transform Layer",  this is an effect. 

The label could read "Affects:" if the hints were "Layer" etc. The tool affects the layer, although this would be less clear and many people would incorrectly say  "it effects the layer".

Other information:
Comment 1 saulgoode 2006-10-02 12:40:27 UTC
While I might agree that "affect" might be grammatically imprecise, I disagree that it should be changed to "effect". Imprecision in a user interface is less offensive than inaccuracy, and the options being presented are not a list of different "effects", they are a list of the different "objects" affected. The user is not being asked choose amongst three different transformations, the "transform" is common to all three options and is determined by the tool -- the "affect" option does nothing to change this.
Comment 2 weskaggs 2006-10-02 21:20:51 UTC
Of "Affect", "Affects", and "Effect", the best is "Affects".  But I don't like any of them.  I think "Transform:" would be better.

If this was done, the tooltips should be changed from "Transform layer", "Transform selection", and "Transform path" to simply "Layer", "Selection", and "Path"; and the line below should be changed from "Transform direction" to simply "Direction".
Comment 3 Sven Neumann 2006-10-02 23:45:14 UTC
I tend to agree with Bill here.
Comment 4 weskaggs 2006-10-03 19:34:01 UTC
Okay, done as described in comment #2.  (Needed to be changed for Move tool too.)

For HEAD:

2006-10-03  Bill Skaggs  <weskaggs@primate.ucdavis.edu>

	* app/tools/tools-enums.[ch]: change labels for transform
	type enum.

	* app/tools/gimpmoveoptions.c:
	* app/tools/gimptransformoptions.c:  change "Affect:" to
	"Move:" or "Transform:", respectively.  Fixes bug #358824.