After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 358811 - Audioscrobbler plugin should store password in keyring
Audioscrobbler plugin should store password in keyring
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Last.fm
git master
Other All
: Normal enhancement
: 2.x
Assigned To: Banshee Maintainers
: 513915 568656 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-10-01 16:47 UTC by Adam McMaster
Modified: 2009-11-09 21:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Adam McMaster 2006-10-01 16:47:12 UTC 
Currently the AudioScrobbler plugin stores its password in plain text in GConf.  Ideally this should be stored in the keyring instead.
Comment 1 Andrew Conkling 2007-08-23 21:43:49 UTC 
I confirm this is still the case for 0.13.1.
Comment 2 severedcross+bugzilla 2007-08-31 22:51:29 UTC 
Do different users have different keyrings or is there one master keyring to rule them all?
Comment 3 Josiah Ritchie - flickerfly 2007-09-11 14:39:07 UTC 
I'm pretty sure the keyring is specific to the logged in gnome user. Is that what you mean Bojan?
Comment 4 severedcross+bugzilla 2007-09-11 15:59:16 UTC 
Exactly what I meant. Thanks! If I remember correctly, this code is already in the source tree somewhere, it just never got integrated (Aaron told me where it is, but I cannot for the life of me remember)
Comment 5 Andrew Conkling 2008-02-04 02:53:48 UTC 
Same for 0.13.2, with one interesting twist: the Last.fm Radio plugin stores the same account password to the 'login' keyring (the same one used by Network-Manager, etc.). So this should be (potentially) easy to port from the Radio plugin to the Audioscrobbler one. :)
Comment 6 Andrew Conkling 2008-02-04 02:54:52 UTC 
*** Bug 513915 has been marked as a duplicate of this bug. ***
Comment 7 Bertrand Lorentz 2008-07-01 12:43:57 UTC 
Banshee 1.0 now stores the password only once, in GConf, and it's hashed.

It looks like the Gnome.Keyring was intentionally removed for 1.0. If it is indeed the case, I'd suggest to mark this one as WONTFIX.
Comment 8 Michael Martin-Smucker 2009-02-18 21:44:59 UTC 
Any update on this one?  It would be nice to clean out some of these old 0.13.x bug reports.
Comment 9 Gabriel Burt 2009-02-18 22:02:10 UTC 
This is really still a valid bug; we should use the keyring, we just got rid of it temporarily b/c it was causing too many problems.
Comment 10 Gabriel Burt 2009-03-09 17:38:13 UTC 
*** Bug 568656 has been marked as a duplicate of this bug. ***
Comment 11 Gabriel Burt 2009-10-27 20:19:09 UTC 
Bulk changing the assignee to banshee-maint@gnome.bugs to make it easier for people to get updated on all banshee bugs by following that address.  It's usually quite apparent who is working on a given bug by the comments and/or patches attached.
Comment 12 Bertrand Lorentz 2009-11-09 21:31:07 UTC 
After the upgrade to the Last.fm 2.0 API (see bug #541227), we're not storing the user's Last.fm password anymore.
We now store a session key in GConf, which only allows access to the API, and only in combination with the Banshee API key and secret.