GNOME Bugzilla – Bug 358613
sink->file is never reset for filesink elements, even though pipeline goes to READY and back to PLAYING
Last modified: 2006-10-02 09:57:09 UTC
Please describe the problem: If a filesink element is used at the end of a pipeline to store contents to file, it should be possible to set the state of the pipeline to READY, change the location property of the filesink element to a new file, and then set the state of the pipeline to PLAYING again, all this in order to store content to another file. This does not work since the sink->file is never reset. Steps to reproduce: Run that tries to change the "location" property of a filesink element on a pipeline in READY state. Actual results: The warning: "WARNING **: Changing the `location' property on filesink when a file is open not supported." is given. Expected results: I would expect the filesink element to start storing content to the new file. Does this happen every time? Yes. Other information:
Created attachment 73714 [details] [review] Fix
Thanks: Patch by: Alessandro Decina <alessandro at nnva org> * plugins/elements/gstfilesink.c: (gst_file_sink_init), (gst_file_sink_set_location), (gst_file_sink_open_file), (gst_file_sink_close_file), (gst_file_sink_event), (gst_file_sink_render): Set file to NULL when closing filesink so that we can set a new filename in READY. Fixes #358613.