After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 358176 - Dia doesn't draw hollow arrow heads with linewidth 0.0 correctly.
Dia doesn't draw hollow arrow heads with linewidth 0.0 correctly.
Status: RESOLVED FIXED
Product: dia
Classification: Other
Component: general
CVS head
Other All
: Normal minor
: 0.96
Assigned To: Dia maintainers
Dia maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-28 19:48 UTC by Michael Duelli
Modified: 2006-10-14 16:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch for hollow arrow heads with line width 0.0 (1.35 KB, patch)
2006-09-28 19:51 UTC, Michael Duelli
committed Details | Review

Description Michael Duelli 2006-09-28 19:48:11 UTC
Please describe the problem:
The bug can be reproduced as described below. It is not only on the screen but also in all export plugins. That's why the bug is in lib/arrows.c

Steps to reproduce:
1. Create an arrow.
2. Change any of the arrow heads to a hollow triangle (some other hollow heads will work too)
3. Set line width of arrow to 0.0 (hairline)


Actual results:
A line is drawn through the hollow part of the arrow head.

Expected results:
The area should keep hollow.

Does this happen every time?
Yes.

Other information:
I have a patch for this.
Comment 1 Michael Duelli 2006-09-28 19:51:36 UTC
Created attachment 73587 [details] [review]
patch for hollow arrow heads with line width 0.0

The error occurs as add_len is always 0 if line width is 0.0, so the line is not set back correctly. The easiest solution to this was to change line width in the beginning as it is done in other parts of the dia code. As this argument was constant, I also had to change the header file.
Comment 2 Hans Breuer 2006-10-14 16:46:16 UTC
Thanks, appplied.

2006-10-14  Hans Breuer  <hans@breuer.org>

	* lib/arrows.[hc] : draw hollow arrow heads with linewidth 0.0 
	correctly. Patch from Michael Duelli fixing bug #358176