After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357698 - followups mangle charset encoding
followups mangle charset encoding
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-1.0 betas
Other Linux
: Normal normal
: 1.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2006-09-25 22:28 UTC by Charles Kerr
Modified: 2006-09-30 02:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
0.113 patch (3.90 KB, patch)
2006-09-25 22:36 UTC, Charles Kerr
none Details | Review
0.114 patch (775 bytes, patch)
2006-09-26 22:36 UTC, Charles Kerr
none Details | Review

Description Charles Kerr 2006-09-25 22:28:50 UTC
This was reported by Artur Jachacy in
http://bugzilla.gnome.org/show_bug.cgi?id=356835
and is being promoted to its own ticket.

Short summary: because BodyPane::create_followup_or_reply()
uses g_mime_message_get_body() rather than traversing through
the mime message and decoding each part by its charset info,
a non-UTF-8 message that displays fine in the body pane can
get mangled upon followup.

For the thread to date, see
http://bugzilla.gnome.org/show_bug.cgi?id=356835 beginning
at comment #13.
Comment 1 Charles Kerr 2006-09-25 22:36:08 UTC
Created attachment 73401 [details] [review]
0.113 patch

Thanks for tracking this down, Christophe. :)
Comment 2 Charles Kerr 2006-09-25 22:40:31 UTC
This looks right to me, but could one of you confirm that
the posting window's quoted text looks right w/this patch?
Comment 3 Christophe Lambin 2006-09-25 22:55:32 UTC
Looks right to me.
Comment 4 Charles Kerr 2006-09-25 23:01:01 UTC
Good, then it's time to roll 0.114. :)
Comment 5 Artur Jachacy 2006-09-26 21:57:28 UTC
Pan (still) mangles quotes from articles with undeclared encoding.
Comment 6 Christophe Lambin 2006-09-26 22:22:07 UTC
this bug doesn't address that problem.  Suggest you open a new one, with an example.
Comment 7 Charles Kerr 2006-09-26 22:34:11 UTC
No, Artur is right.  It's a bug in the patch in comment #1.
I'll put up another patch.
Comment 8 Charles Kerr 2006-09-26 22:36:26 UTC
Created attachment 73469 [details] [review]
0.114 patch

Fixes a bug in the previous patch which correctly used the mime
part's encoding as the first fallback, but wrongly did not use
the group's charset as the secondary fallback.
Comment 9 Charles Kerr 2006-09-26 22:43:23 UTC
Artur, could you please give the new patch a try?
Comment 10 Artur Jachacy 2006-09-26 23:13:53 UTC
It's fixed.