GNOME Bugzilla – Bug 357556
Insert key sticks after running test keystroke files
Last modified: 2006-09-28 16:24:31 UTC
When running the test keystroke files for both gnome-terminal and gedit the insert key will frequently be stuck after the test finishes. If any of these tests are run and orca is not exited orca will behave as if the insert key is still being held down. This could be an ubuntu edgy issue as I have been only seeing this for the last couple days. The problem does not happen every time but it does happen quite often. To reproduce, just run a standalone keystroke file and then press any of the arrow keys when it finishes. You will probably hear a change in the pitch or rate.
Are you getting COMM_FAILURE's at the end of these tests Mike? I think this might be a duplicate of bug #357248. If so, we need to improve the handling of CORBA.COMM_FAILURE in processInputEvent() in input_event.py.
This might be a simple problem with the keystroke files themselves. Take a look at the end of the keystroke files - it may be that they don't include any key release events (type=1) for the Insert key. Remember also that you can run src/tools/sanity_check.py on a keystroke file to catch some gross errors such as missing release events.
Yup, looks like this is indeed the problem. Certainly in .../test/keystrokes/gedit/file-open.keys
This seems to be happening because I need to use the insert+pause to close the keystroke file. It seems as though the keystroke file is being closed before the insert key is released.
Created attachment 73568 [details] [review] Patch to fix the problem. Well, it looks like there was a really good reason why the special hot-key for starting/stopping recording of keystrokes in Orca was Pause (rather than Insert-Pause). Because there was already code in place to not write out the Pause keystroke. I've reverted it back to just "Pause" and adjusted the "don't write pause keystrokes" to recognize F21 (which is the Pause key on my Sun type 6 keyboard).
Changes checked in CVS HEAD. Closing as FIXED.