After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357531 - [subparse] problem if markup is not closed
[subparse] problem if markup is not closed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.x
Other Linux
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-24 22:36 UTC by Guillaume Desmottes
Modified: 2006-10-20 17:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Description Guillaume Desmottes 2006-09-24 22:36:26 UTC 
Let's say we have a .srt file with this sequence of 3 subtitles:
- first
- <i>second
- <i>third

When you play the video, it displays:
- first
- first
- first

The subtitles files is wrong of course, markups should be closed, but gst should handle that in a better way: 
- add the missing </i> and display the subtitle in italic
- or escape the <i> and display it with the subtitle
Comment 1 Tim-Philipp Müller 2006-10-20 17:02:44 UTC 
Should be fixed in CVS now:

 2006-10-20  Tim-Philipp Müller  <tim at centricular dot net>

        * gst/subparse/gstsubparse.c: (subrip_fix_up_markup),
        (parse_subrip), (handle_buffer):
          Add missing closing tags for markup and fix broken markup,
          otherwise pango won't render anything (fixes #357531). Also,
          make sure the text we send out is always NUL-terminated
          (better safe than sorry etc.).

        * tests/check/elements/subparse.c: (test_srt_do_test),
        (test_srt):
          Some more tests for .srt, and test for the above.