After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357492 - [patch] Composer: Crash on deleting an Attachment
[patch] Composer: Crash on deleting an Attachment
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
2.8.x (obsolete)
Other All
: Urgent critical
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 353382 358779 365403 365489 366449 367863 368379 368563 369555 369918 369978 370007 370830 370928 371496 372125 372622 374678 385370 385587 387986 398304 399553 400135 400261 404562 405273 405684 417440 418530 431494 431616 444865 481319 497090 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-24 18:17 UTC by Graham Cranston
Modified: 2013-09-10 14:04 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
debug output (37.39 KB, text/plain)
2006-09-28 00:48 UTC, Graham Cranston
  Details
proposed patch (2.06 KB, patch)
2006-11-03 16:57 UTC, parthasarathi susarla
committed Details | Review

Description Graham Cranston 2006-09-24 18:17:22 UTC
What were you doing when the application crashed?
moved 4 attachments from one email message (in the outbox.  Was too large to send) to a new message then attempted to delete the 4 from the first message.


Distribution: Ubuntu 6.10 (edgy)
Gnome Release: 2.16.0 2006-09-04 (Ubuntu)
BugBuddy Version: 2.16.0

Memory status: size: 323993600 vsize: 0 resident: 323993600 share: 0 rss: 57376768 rss_rlim: 0
CPU usage: start_time: 1159117632 rtime: 0 utime: 6197 stime: 0 cutime:5611 cstime: 0 timeout: 586 it_real_value: 0 frequency: 0

Backtrace was generated from '/usr/bin/evolution-2.8'

(no debugging symbols found)
Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
(no debugging symbols found)
[Thread debugging using libthread_db enabled]
[New Thread -1233365328 (LWP 28134)]
[New Thread -1350571104 (LWP 28607)]
[New Thread -1342178400 (LWP 28603)]
[New Thread -1332286560 (LWP 28155)]
[New Thread -1323791456 (LWP 28152)]
[New Thread -1315398752 (LWP 28151)]
[New Thread -1306612832 (LWP 28148)]
[New Thread -1297228896 (LWP 28147)]
[New Thread -1288795232 (LWP 28144)]
[New Thread -1280365664 (LWP 28142)]
0xffffe410 in __kernel_vsyscall ()

Comment 1 Karsten Bräckelmann 2006-09-24 19:44:36 UTC
Thanks for the bug report. Unfortunately, that stack trace is not very useful in determining the cause of the crash. Can you get us one with debugging symbols? Please see http://live.gnome.org/GettingTraces for more information on how to do so.

Can you reproduce the crash?
Comment 2 Graham Cranston 2006-09-28 00:48:17 UTC
Created attachment 73526 [details]
debug output

debug
Comment 3 Karsten Bräckelmann 2006-09-28 01:00:53 UTC
Thanks for the stacktrace. :)

REOPENing. Pasting the relevant part here for convenient searching:

  • #4 <signal handler called>
  • #5 e_attachment_bar_remove_selected
    at e-attachment-bar.c line 493
  • #6 key_press_event
    at e-msg-composer.c line 3756
  • #7 _gtk_marshal_BOOLEAN__BOXED
    at gtkmarshalers.c line 83
  • #8 IA__g_closure_invoke
    at gclosure.c line 490

Comment 4 Karsten Bräckelmann 2006-09-28 01:06:36 UTC
Although the stacktraces do not match entirely, I believe this to be the same issue as bug 353382. The description is the same, and these are the only crashes in e_attachment_bar_remove_selected() so far, no other duplicates at all. The difference in the stacktraces likely is due to different actions (keyboard shortcut vs. context menu).
Comment 5 Karsten Bräckelmann 2006-09-28 01:06:39 UTC
*** Bug 353382 has been marked as a duplicate of this bug. ***
Comment 6 Karsten Bräckelmann 2006-10-01 14:10:51 UTC
*** Bug 358779 has been marked as a duplicate of this bug. ***
Comment 7 Karsten Bräckelmann 2006-10-01 14:11:34 UTC
Component Mailer.
Comment 8 Karsten Bräckelmann 2006-10-31 18:18:49 UTC
Confirming.
Comment 9 Karsten Bräckelmann 2006-10-31 18:19:42 UTC
*** Bug 366449 has been marked as a duplicate of this bug. ***
Comment 10 Karsten Bräckelmann 2006-10-31 18:20:00 UTC
*** Bug 367863 has been marked as a duplicate of this bug. ***
Comment 11 Karsten Bräckelmann 2006-10-31 18:24:09 UTC
From bug 366449:

  • #4 <signal handler called>
  • #5 e_attachment_bar_remove_selected
    at e-attachment-bar.c line 478
  • #6 key_press_event
    at e-msg-composer.c line 3757
  • #7 _gtk_marshal_BOOLEAN__BOXED
    from /usr/lib/libgtk-x11-2.0.so.0


Priority urgent, Target Milestone 2.8.

Note:  According to the descriptions, there are a *lot* of duplicates
       out there (unfortunately with a corrupt stacktrace).
Comment 12 Karsten Bräckelmann 2006-10-31 20:26:51 UTC
*** Bug 368379 has been marked as a duplicate of this bug. ***
Comment 13 Karsten Bräckelmann 2006-11-01 22:36:22 UTC
*** Bug 368563 has been marked as a duplicate of this bug. ***
Comment 14 Karsten Bräckelmann 2006-11-02 18:11:25 UTC
*** Bug 365403 has been marked as a duplicate of this bug. ***
Comment 15 parthasarathi susarla 2006-11-03 16:57:00 UTC
Created attachment 75947 [details] [review]
proposed patch

This bug fixes the crash and also fixes the problem of the attachments not getting deleted.
Comment 16 Karsten Bräckelmann 2006-11-03 21:46:48 UTC
*** Bug 365489 has been marked as a duplicate of this bug. ***
Comment 17 Karsten Bräckelmann 2006-11-04 02:55:23 UTC
*** Bug 369555 has been marked as a duplicate of this bug. ***
Comment 18 Karsten Bräckelmann 2006-11-04 04:19:32 UTC
*** Bug 369918 has been marked as a duplicate of this bug. ***
Comment 19 Karsten Bräckelmann 2006-11-04 04:40:22 UTC
*** Bug 369978 has been marked as a duplicate of this bug. ***
Comment 20 Karsten Bräckelmann 2006-11-04 04:40:37 UTC
*** Bug 370007 has been marked as a duplicate of this bug. ***
Comment 21 Karsten Bräckelmann 2006-11-05 17:20:32 UTC
*** Bug 370830 has been marked as a duplicate of this bug. ***
Comment 22 Karsten Bräckelmann 2006-11-05 17:20:35 UTC
*** Bug 370928 has been marked as a duplicate of this bug. ***
Comment 23 Karsten Bräckelmann 2006-11-06 19:22:46 UTC
*** Bug 371496 has been marked as a duplicate of this bug. ***
Comment 24 Karsten Bräckelmann 2006-11-06 19:24:54 UTC
*poke*

What about committing the patch? So we just missed to get it in into 2.9.2, eh?
Comment 25 pawel.kowalczyk 2006-11-06 20:18:39 UTC
(In reply to comment #24)
> *poke*
> 
> What about committing the patch? So we just missed to get it in into 2.9.2, eh?
> 

Is there a patch I can download to fix this problem? I'm using Ubuntu and my Evolution seems to be up-to-date.

P.
Comment 26 Karsten Bräckelmann 2006-11-07 22:22:54 UTC
*** Bug 372125 has been marked as a duplicate of this bug. ***
Comment 27 Karsten Bräckelmann 2006-11-07 22:29:02 UTC
Pawel, the (source code) patch is attached to this report. However, unless you are building from source, you'd need to wait for your distro to release a version that contains this fix.
Comment 28 Srinivasa Ragavan 2006-11-08 17:08:56 UTC
Partha it fixes the bug. But is that another ptr array req? you can just unref the attachment u get. I feel unnecessary iterations included.
Comment 29 Karsten Bräckelmann 2006-11-08 21:42:00 UTC
*** Bug 372622 has been marked as a duplicate of this bug. ***
Comment 30 parthasarathi susarla 2006-11-11 09:45:15 UTC
(In reply to comment #28)
> Partha it fixes the bug. But is that another ptr array req? you can just unref
> the attachment u get. I feel unnecessary iterations included.
> 

Srini, the earlier code used to unref it within the loop, but what happens is that the items list gets unrefed too (the attachemnts array data is linked to the items) - so it becomes necessary that we have another array. 


Shall i commit this??
Comment 31 Srinivasa Ragavan 2006-11-13 06:06:49 UTC
Got it. Please commit to HEAD and Stable.
Comment 32 parthasarathi susarla 2006-11-14 19:48:18 UTC
Patch committed. Thanks.
Comment 33 Srinivasa Ragavan 2006-11-16 17:34:34 UTC
Partha you missed to putinto stable. Done :)
Comment 34 ebbywiselyn 2006-12-07 09:59:11 UTC
*** Bug 374678 has been marked as a duplicate of this bug. ***
Comment 35 palfrey 2006-12-13 18:27:17 UTC
*** Bug 385370 has been marked as a duplicate of this bug. ***
Comment 36 palfrey 2006-12-13 21:46:57 UTC
*** Bug 385587 has been marked as a duplicate of this bug. ***
Comment 37 Pascal Terjan 2006-12-27 10:22:29 UTC
*** Bug 387986 has been marked as a duplicate of this bug. ***
Comment 38 Susana 2007-01-19 13:42:34 UTC
*** Bug 398304 has been marked as a duplicate of this bug. ***
Comment 39 palfrey 2007-01-23 13:59:50 UTC
*** Bug 399553 has been marked as a duplicate of this bug. ***
Comment 40 Susana 2007-01-24 12:35:35 UTC
*** Bug 400135 has been marked as a duplicate of this bug. ***
Comment 41 Kjartan Maraas 2007-02-07 18:41:20 UTC
*** Bug 400261 has been marked as a duplicate of this bug. ***
Comment 42 Kjartan Maraas 2007-02-07 18:41:45 UTC
*** Bug 405273 has been marked as a duplicate of this bug. ***
Comment 43 André Klapper 2007-02-09 01:09:36 UTC
*** Bug 404562 has been marked as a duplicate of this bug. ***
Comment 44 André Klapper 2007-02-09 01:09:36 UTC
*** Bug 405684 has been marked as a duplicate of this bug. ***
Comment 45 Susana 2007-03-13 02:00:12 UTC
*** Bug 417440 has been marked as a duplicate of this bug. ***
Comment 46 Susana 2007-03-15 15:32:02 UTC
*** Bug 418530 has been marked as a duplicate of this bug. ***
Comment 47 palfrey 2007-04-26 14:28:23 UTC
*** Bug 431494 has been marked as a duplicate of this bug. ***
Comment 48 palfrey 2007-04-26 14:32:56 UTC
*** Bug 431616 has been marked as a duplicate of this bug. ***
Comment 49 André Klapper 2007-06-11 21:27:04 UTC
*** Bug 444865 has been marked as a duplicate of this bug. ***
Comment 50 André Klapper 2007-10-19 00:56:35 UTC
*** Bug 481319 has been marked as a duplicate of this bug. ***
Comment 51 Akhil Laddha 2008-06-19 09:28:28 UTC
*** Bug 497090 has been marked as a duplicate of this bug. ***