GNOME Bugzilla – Bug 357323
Revoked UIDs are not indicated
Last modified: 2006-12-21 21:58:40 UTC
Please describe the problem: My public key has two UIDs, one of which is revoked. However this is not reflected in the key list. I suggest hiding revoked UIDs, or displaying them in a struck-through style. To compare with other programs, gpg --list-keys and gpa both only display the default UID for a key; secondary UIDs are not displayed. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
I've been working on adding a strikethrough element to the markup in libseahorse/seahorse-pgp-key.c:seahorse_pgp_key_get_name_markup(). The uid->revoked property appears to get set properly at first but then disappears as keys are refreshed from the keyservers. This is most likely the same problem that's causing the disappearing photoids on refreshes.
Adam, could you post your patch? I'll apply it to my tree and take a look around for that bug you're talking about. In any case I think that revoked UIDs should probably only be displayed in the properties dialog (with the 'strikethrough' style) and not the main window.
Created attachment 73570 [details] [review] Strikes through expired UIDs
Nice. Committed with some changes. 2006-12-21 Nate Nielsen <nielsen@memberwebs.com> * libseahorse/seahorse-pgp-key.c: Add strikethrough for expired, revoked, disabled keys. Patch by Adam Schreiber. Fixes bug #357323