After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357323 - Revoked UIDs are not indicated
Revoked UIDs are not indicated
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
0.9.5
Other All
: Normal normal
: 1.0.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2006-09-23 11:42 UTC by Sam Morris
Modified: 2006-12-21 21:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Strikes through expired UIDs (819 bytes, patch)
2006-09-28 16:39 UTC, Adam Schreiber
none Details | Review

Description Sam Morris 2006-09-23 11:42:20 UTC
Please describe the problem:
My public key has two UIDs, one of which is revoked. However this is not reflected in the key list. I suggest hiding revoked UIDs, or displaying them in a struck-through style.

To compare with other programs, gpg --list-keys and gpa both only display the default UID for a key; secondary UIDs are not displayed.

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Adam Schreiber 2006-09-23 17:10:27 UTC
I've been working on adding a strikethrough element to the markup in libseahorse/seahorse-pgp-key.c:seahorse_pgp_key_get_name_markup().  The uid->revoked property appears to get set properly at first but then disappears as keys are refreshed from the keyservers.  This is most likely the same problem that's causing the disappearing photoids on refreshes.
Comment 2 Stef Walter 2006-09-28 15:14:52 UTC
Adam, could you post your patch? I'll apply it to my tree and take a look around for that bug you're talking about. 

In any case I think that revoked UIDs should probably only be displayed in the properties dialog (with the 'strikethrough' style) and not the main window. 
Comment 3 Adam Schreiber 2006-09-28 16:39:49 UTC
Created attachment 73570 [details] [review]
Strikes through expired UIDs
Comment 4 Stef Walter 2006-12-21 21:58:40 UTC
Nice. Committed with some changes.

2006-12-21  Nate Nielsen  <nielsen@memberwebs.com>

    * libseahorse/seahorse-pgp-key.c: Add strikethrough for expired, 
    revoked, disabled keys. Patch by Adam Schreiber. Fixes bug #357323