After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357289 - [riff] riff parser can't detect aac audio stream
[riff] riff parser can't detect aac audio stream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
0.10.10
Other All
: Normal normal
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-23 05:44 UTC by Young-Ho Cha
Modified: 2006-09-23 11:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
add aac id and handler in riff parser (1.87 KB, patch)
2006-09-23 05:49 UTC, Young-Ho Cha 		committed Details | Review

Description Young-Ho Cha 2006-09-23 05:44:13 UTC 
Please describe the problem:
Some avi file that contains AAC audio stream, can't decode audio stream.

Steps to reproduce:
1. play media file with totem that use gstreamer backend 
2. 
3. 


Actual results:
totem prints follow message.
** Message: don't know how to handle audio/x-avi-unknown, codec_id=(int)255

Expected results:
decode audio stream.

Does this happen every time?
yes

Other information:
As same reason with bug 350157, gst_riff_create_audio_caps() functions can't handle aac stream.

I'll attach a patch.
Comment 1 Young-Ho Cha 2006-09-23 05:49:17 UTC 
Created attachment 73258 [details] [review]
add aac id and handler in riff parser

There is one parameter - "mpegversion" for aac decode element. but I don't know how can detect that.

Currently, I set "mpegversion" to "2" as fixed value.

Does anyone have a some nice idea?
Comment 2 Wim Taymans 2006-09-23 08:51:48 UTC 
Looking at xine/mplayer, it appears that this is handled as "mp4a", which is always version 4. Can you check that this works as well? I have no avi with AAC inside.

        Patch by: Young-Ho Cha <ganadist at chollian dot net>

        * gst-libs/gst/riff/riff-ids.h:
        * gst-libs/gst/riff/riff-media.c: (gst_riff_create_audio_caps),
        (gst_riff_create_audio_template_caps):
        Added MPEG-4 AAC and id and caps. Fixes #357289
        Added WMA9 Lossless id.
Comment 3 Young-Ho Cha 2006-09-23 11:03:32 UTC 
It works well.

Thank you.