After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 357145 - Some popt remains
Some popt remains
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonobo
CVS HEAD
Other All
: Normal normal
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2006-09-22 03:11 UTC by Daniel Macks
Modified: 2008-01-25 14:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.12 KB, patch)
2007-01-25 12:14 UTC, Christian Persch
none Details | Review

Description Daniel Macks 2006-09-22 03:11:18 UTC
libbonobo-2.16 removed use of popt (thanks to the patch in bug #336610), but that work appears incomplete. In bonobo-activation/bonobo-activation-init.h, there is:

#include <popt.h>
[...]
extern struct poptOption bonobo_activation_popt_options[];

and configure.in still appears to have mandatory requirements for popt as well. That means I still need popt installed in order to build libbonobo, and even to compile against it. Is that struct actually used anywhere anymore? There is no linking against libpopt during the build process. Should it be protected with

#ifndef BONOBO_DISABLE_DEPRECCATED

so that it's only exposed if one explicitly requests it?
Comment 1 Michael Meeks 2006-09-22 08:28:38 UTC
sounds good to me; go for it :-)
Of course, we can't remove the 'extern' decl. since people may have been using this, but your suggestion sounds great; Christian Persch seems to have done the work - Christian ?
Comment 2 Christian Persch 2006-09-22 18:22:26 UTC
Yes, it seems ok to add #ifndef:s around the popt.h inclusion and the extern struct poptOption... in bonobo-activation-init.h.
Comment 3 Kjartan Maraas 2007-01-25 11:20:25 UTC
Anyone care enough to whip up a patch? :-)
Comment 4 Christian Persch 2007-01-25 12:14:03 UTC
Created attachment 81171 [details] [review]
patch
Comment 5 Kjartan Maraas 2007-01-26 09:50:12 UTC
Commited.
Comment 6 Daniel Macks 2008-01-21 08:01:11 UTC
As of libbonobo-2.20.3 (and probably much earlier), the only use of popt itself is its .h for some typedefs (no symbols) and the popt library is not used. There is still a configure test for libpopt:

AC_CHECK_LIB(popt, poptStrippedArgv, POPT_LIBS=-lpopt, AC_MSG_ERROR([You must have popt version 1.5 or greater installed.]))
AC_SUBST(POPT_LIBS)

but POPT_LIBS is not used in any makefile. Time to scrap that configure test?
Comment 7 Christian Persch 2008-01-24 11:58:51 UTC
Yes, if it's unused the configure check should be removed.
Comment 8 Kjartan Maraas 2008-01-25 14:56:50 UTC
Commited. Thanks.