After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356924 - [PATCH] found a pair of unlocalised strings
[PATCH] found a pair of unlocalised strings
Status: RESOLVED FIXED
Product: gnome-cups-manager
Classification: Deprecated
Component: gnome-cups-manager
unspecified
Other All
: Normal trivial
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2006-09-20 16:31 UTC by Robert Millan
Modified: 2009-09-03 13:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.16 KB, patch)
2006-09-20 16:32 UTC, Robert Millan 		needs-work Details | Review

Description Robert Millan 2006-09-20 16:31:12 UTC 
I think the strings "Raw Queue" and "Generic" could well be localised.

Patch follows.
Comment 1 Robert Millan 2006-09-20 16:32:01 UTC 
Created attachment 73096 [details] [review]
patch
Comment 2 Jordi Mallach 2006-09-20 16:45:17 UTC 
Robert is probably right here.
Comment 3 Jody Goldberg 2006-09-21 18:05:16 UTC 
Comment on attachment 73096 [details] [review]
patch

The 'Generic' portion is correct.  The 'Raw Queue' change is not universally valid C.  That is an initializer for a static variable.  We should translate that when it is used, not when it is declared.
Comment 4 Robert Millan 2006-09-21 18:29:26 UTC 
Ah, right.  Sorry I overlooked this.  I don't have time to provide a proper fix atm.  Please can you apply the "Generic" part at least?

Thanks!
Comment 5 Kjartan Maraas 2006-11-19 11:03:47 UTC 
Commited the generic part. Should the other be marked with N_()? And where should it be sent to gettext later? The only place I see *generic used is in the add_vendor_aliases() call with "Generic" in it?
Comment 6 Kjartan Maraas 2008-01-29 13:09:39 UTC 
Moving all gnome-cups-manager bugs to new product. Filter on Kjartan's spring cleaning.
Comment 7 Kjartan Maraas 2009-09-02 11:20:57 UTC 
Closing this. Please reopen if there's more work to be done here.
Comment 8 Jordi Mallach 2009-09-03 13:47:59 UTC 
Reading the bug log, apparently another string still needs translating, but I didn't check the current codebase.