GNOME Bugzilla – Bug 356575
Add a way to change gnome-keyring password
Last modified: 2007-06-18 14:31:01 UTC
Now that seahorse supports gnome-keyring management, it should also be able to change the password of the keyring (also see bug 38088)
Is that bug on a different bugzilla? It doesn't appear to exist.
Sorry, that should have been 338088 on bgo. It's about adding password changing support to gnome-keyring manager.
Yay. A lot of people have been asking about this functionality. Will implement.
Created attachment 79032 [details] [review] Adds function to GkeyringSource This is a pretty simple function that hooks up to the synchronous interface for changing a gnome keyring password. ToDo: * Determine what to do with the result code as it should probably be more than an int, but nothing else includes the gnome keyring header. * Hook up to UI. The change password/passphrase UI could probably be reused here. * Interface with the main application. I'm not sure how this functionality should be exposed. Perhaps in the preferences dialog? There could be a tab that lists the available key rings in a treeview and then one could be selected and a change password button could be made sensitive. We could also add buttons to create and delete keyrings. /end braindump
Created attachment 79033 [details] [review] Handles return message *Whoops* After digging a little I realized handling the error messages was already implemented.
Thanks for working on this... A UI idea I've been kicking around for a while would be to have this main password in bold and expandable, with all the other gnome-keyring passwords underneath it. Perhaps something like: + *Nate's Master Password* - SMB password - HTTP password Then we could have other 'major' passwords like: + *Nate's Login Password* Also this would allow us to support multiple keyrings (such an overloaded term) which gnome-keyring supports. Obviously this would mean changing significant bits of the plumbing that the GtkTreeStore uses to show the passwords.
I'm not sure that exposing the multiple key rings functionality there is needed. I'm not sure about the use case for them anyway. When you're saving a password to a key ring, do you even get the choice about which to save it to?
Additionally, for the Keyring management info to go in the preferences dialog, the keyring key source and accouterments will have to be moved to libseahorse. I can't work on this any more until we decide what to do. I have implemented an operation to list the keyrings but won't create any more helper functions for the now.
Created attachment 79145 [details] [review] Adds list keyrings operation
Nate, Following the discussion on D-D-L regarding the use of multiple key rings, where do you plan on taking gnome-keyring so that I may work on implementing missing gnome-keyring-manager functionality?
It's almost certain that gnome-keyring will continue to support multiple keyrings. Jon Nettleton came up with an alternate solution which doesn't take away any current gnome-keyring functionality. However I might suggest not confusing the user needlessly with multiple keyrings in seahorse, but focusing on the default keyring.
Will do. In UI, should I refer to it as the Default Key Ring's Master Password, or GNOME Keyring's Master password so that I may be consistent with your plans? I would guess that the second would confuse users less if other key rings aren't being exposed.
Created attachment 90084 [details] [review] changes the master password on the default ring This patch adds a tab onto the preferences notepad that allows for changing the default keyring's master password. If there are no objections to phrasing on the tab, I'll commit it.