After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356389 - Include Tango colors
Include Tango colors
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-17 13:24 UTC by Wouter Bolsterlee (uws)
Modified: 2006-10-06 10:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
Proposes fix (2.60 KB, patch)
2006-09-19 09:10 UTC, Wouter Bolsterlee (uws) 		accepted-commit_after_freeze Details | Review

Description Wouter Bolsterlee (uws) 2006-09-17 13:24:38 UTC 
Now that more and more icons/artwork uses the Tango color scheme (and icons), it would probably be a good idea to include a Tango-terminal pallette to the built-in lits of color presets.

More details:
http://uwstopia.nl/blog/2006/07/tango-terminal
Comment 1 Behdad Esfahbod 2006-09-18 16:01:16 UTC 
Feel free to attach a patch to add an alternative colour scheme!
Comment 2 Wouter Bolsterlee (uws) 2006-09-19 08:57:25 UTC 
Where exactly are the color palettes defined? Adding a new entry sounds pretty straight-forward by adding some lines similar to these:

| ./src/profile-editor.c:
| { N_("Linux console"), terminal_palette_linux },
|./src/terminal-profile.h:
| extern const GdkColor terminal_palette_linux[TERMINAL_PALETTE_SIZE];

But I didn't find the location of the actual color values after some grepping... any clue?
Comment 3 Wouter Bolsterlee (uws) 2006-09-19 08:59:38 UTC 
Nevermind, it's in terminal-profile.c
Comment 4 Wouter Bolsterlee (uws) 2006-09-19 09:10:59 UTC 
Created attachment 73024 [details] [review]
Proposes fix

This patch adds the tango color palette to the list of built-in palettes. See http://uwstopia.nl/blog/2006/07/tango-terminal for a screenshot.
Comment 5 Wouter Bolsterlee (uws) 2006-09-29 09:19:59 UTC 
Mind if I commit this to CVS?
Comment 6 Behdad Esfahbod 2006-10-02 19:20:41 UTC 
Should be done after we branch.
Comment 7 Wouter Bolsterlee (uws) 2006-10-06 10:47:48 UTC 
2006-10-06  Wouter Bolsterlee  <wbolster@gnome.org>

    * src/profile-editor.c:
    * src/terminal-profile.c:
    * src/terminal-profile.h:
    Include Tango color scheme.  Fixes bug #356389.