GNOME Bugzilla – Bug 356258
make thunderbird plugin work
Last modified: 2008-03-27 18:29:24 UTC
I have put the following patch in the Fedora package, to make the thunderbird plugin work.
Created attachment 72896 [details] [review] patch
Created attachment 75934 [details] [review] my approach to get thunderbird working Hi, I couldn't get it to work with your patch. I looked at http://www.interveritas.net/thunderbird/ how it was implemented before and used this method. I also added a "check" if it's an URI or not, as file-roller gives the file back as "/tmp/whatever/file.tar.gz" and not as "file:///tmp/whatever/file.tar.gz". Best regards, Whoopie
Created attachment 84428 [details] [review] updated patch for nautilus-sendto 0.10 updated patch for nautilus-sendto 0.10
Created attachment 89610 [details] [review] thunderbird support only difference is - t_cmd = g_find_program_in_path ("mozilla-thunderbird"); + t_cmd = g_find_program_in_path ("thunderbird"); so that it works with thunderbird 2.0 in Ubuntu Gutsy.
Created attachment 94861 [details] [review] updated patch for nautilus-sendto 0.12 This patch is an update to work with nautilus-sendto 0.12 and Thunderbird 2.0.
Created attachment 95204 [details] [review] fix thunderbird name and attachment escaping This patch fixes the thunderbird name and the escaping for the attachment parameter.
Comment on attachment 95204 [details] [review] fix thunderbird name and attachment escaping >--- nautilus-sendto-0.12-orig/src/plugins/thunderbird.c 2007-09-09 10:28:11.000000000 +0200 >+++ nautilus-sendto-0.12/src/plugins/thunderbird.c 2007-09-09 11:15:35.000000000 +0200 <snip> >- g_string_append_printf (mailto," attachment='\"%s\"'",file_list->data); >+ g_string_append_printf (mailto,"\"attachment='%s",file_list->data); Please follow the coding style used. Also, why not use g_shell_quote instead of putting the quotes by hand?
*** Bug 510182 has been marked as a duplicate of this bug. ***
2008-03-27 Bastien Nocera <hadess@hadess.net> * configure.in: Allow distributors to override the default thunderbird binary name with --with-thunderbird-name=XXX, enable the thunderbird plugin by default * src/nautilus-sendto-command.c (send_button_cb): Fix a memory leak * src/plugins/thunderbird.c (init), (send_files): Attachments are passed as URIs, so quote them as expected (Closes: #356258)