After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356131 - RFB 3.8 support for vino
RFB 3.8 support for vino
Status: RESOLVED FIXED
Product: vino
Classification: Applications
Component: Server
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Vino Maintainer(s)
Vino Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2006-09-15 14:24 UTC by Dan Winship
Modified: 2006-10-16 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (3.63 KB, patch)
2006-09-15 14:25 UTC, Dan Winship
accepted-commit_now Details | Review

Description Dan Winship 2006-09-15 14:24:34 UTC
This adds RFB 3.8 support to vino. The only changes relative to 3.7 are two
tiny changes to authentication.

However, the patch still makes vino only advertise 3.7 support by default,
because 3.8 requires the server to send an error message if authentication
fails, but the error message has to be iso8859-1 encoded, meaning it can't
be fully localized, meaning that in most cases, the user will fare better
with a generic-but-localized client-side error message than with the
specific-but-unlocalized server-side error message. (Particularly since we
only support password auth, and there's only one error that can occur with
it...)

So what's the point of adding 3.8 support if we only advertise 3.7 support?

    1. At least one client (RealVNC 4.1.9) is broken and requires the server
       to use 3.8 even if it only advertises 3.7 (and so it will hang when
       connecting to vino if you *don't* use password auth because of the
       protocol changes).

    2. In the future, we may need/want 3.8 support for other reasons (as a
       stepping stone to 3.9?), and I've already written the code, so here
       it is.
Comment 1 Dan Winship 2006-09-15 14:25:11 UTC
Created attachment 72855 [details] [review]
patch
Comment 2 Mark McLoughlin 2006-10-16 07:40:48 UTC
Patch looks good to commit Dan.

One minor nit:

+	    rfbAuthPasswordChecked (cl, RFB_CLIENT_ACCEPT);

this code doesn't use the "space-between-function-name-and-parenthesis" style
Comment 3 Mark McLoughlin 2006-10-16 07:51:19 UTC
This can go on the gnome-2-16 branch as well as HEAD, I think
Comment 4 Dan Winship 2006-10-16 14:15:31 UTC
committed to HEAD and gnome-2-16