After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356124 - [a11y] nautilus-file-management-properties.glade need to specify label-for and labeled-by relations
[a11y] nautilus-file-management-properties.glade need to specify label-for an...
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: File Properties Dialog
0.x.x [obsolete]
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 338349 (view as bug list)
Depends on:
Blocks: 356042
 
 
Reported: 2006-09-15 13:18 UTC by Willie Walker
Modified: 2007-06-04 14:45 UTC
See Also:
GNOME target: ---
GNOME version: 2.17/2.18

Attachments
Patch to add required relations (6.41 KB, patch)
2006-10-05 14:03 UTC, padraig.obriain 		none Details | Review
Corrected patch (6.41 KB, patch)
2006-11-03 15:24 UTC, padraig.obriain 		committed Details | Review
Patch to do one more relationship (1.38 KB, patch)
2006-11-15 01:09 UTC, Willie Walker 		committed Details | Review

Description Willie Walker 2006-09-15 13:18:45 UTC 
The nautilus file management properties dialog has a number of components that have labels, but the label-for and labeled-by relations are not set.  This makes it very difficult for a screen reader to announce the name of the component.  One needs to go through the various tabs in this dialog and make sure the proper relations are set up.
Comment 1 padraig.obriain 2006-10-05 14:03:44 UTC 
Created attachment 74058 [details] [review]
Patch to add required relations
Comment 2 padraig.obriain 2006-10-10 14:18:09 UTC 
*** Bug 338349 has been marked as a duplicate of this bug. ***
Comment 3 padraig.obriain 2006-11-03 15:24:18 UTC 
Created attachment 75938 [details] [review]
Corrected patch
Comment 4 Martin Wehner 2006-11-06 01:20:21 UTC 
Thanks, it's in CVS:

2006-11-06  Martin Wehner  <martin.wehner@gmail.com>

	* src/nautilus-file-management-properties.glade:
	Specify label-for and labelled-by atk relations. (#356124)

	Patch from Padraig O'Briain  <padraig.obriain@sun.com>
Comment 5 Willie Walker 2006-11-15 01:09:39 UTC 
Created attachment 76612 [details] [review]
Patch to do one more relationship

The Date Format label in the "Display" tab was missing a realtionship as well.  This patch adds it, and I tested it with Orca and at-poke.
Comment 6 Willie Walker 2007-02-26 20:44:39 UTC 
Is the patch from the previous comment something that someone can check in for GNOME 2.18 (please)?
Comment 7 Willie Walker 2007-05-23 20:19:56 UTC 
(In reply to comment #6)
> Is the patch from the previous comment something that someone can check in for
> GNOME 2.18 (please)?

Anyone willing to check the patch in for GNOME 2.19.3?  I'd hate to see this languish -- it's a very simple patch with good usability impact.
Comment 8 Alexander Larsson 2007-06-04 06:59:10 UTC 
Looks good to me. I can't apply it atm, but if you or someone else can that would be good.
Comment 9 Willie Walker 2007-06-04 14:45:46 UTC 
Committed and closing this as FIXED.  Thanks!  Look forward to the 2.19.3 release.  :-)