After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 356004 - [mpeg2dec] memory corruption
[mpeg2dec] memory corruption
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
0.10.3
Other Linux
: Normal normal
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-14 18:50 UTC by Yves Lefebvre
Modified: 2006-09-15 16:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for this bug (508 bytes, patch)
2006-09-14 18:54 UTC, Yves Lefebvre 		committed Details | Review

Description Yves Lefebvre 2006-09-14 18:50:34 UTC 
Hi,

I got some problem with a particular mpeg file and my own application. It was a crash that occurs sometime. playing with gst-launch is fine.

Valgrind show me lots of invalid write.

I managed to track down the problem. There is a bug in the init_dummybuf function.
I will post the patch.

It may be related to bug 327350 since the gdb output look familiar to what I was getting with this problem.
Comment 1 Yves Lefebvre 2006-09-14 18:54:50 UTC 
Created attachment 72809 [details] [review]
patch for this bug

This patch for the init_dummybuf function does exactly what is already (correclty) done in the gst_mpeg2dec_alloc_buffer function regarding buf[2] pointer.
Comment 2 Wim Taymans 2006-09-15 16:15:06 UTC 
yep, thanks, very correct. Fixed in CVS:  

        Patch by: Yves Lefebvre <ivanohe at abacom dot com>

        * ext/mpeg2dec/gstmpeg2dec.c: (init_dummybuf):
        Fix initialisation dummy buffer, the offsets are relative to the start
        of the buffers. Fixes #356004.