GNOME Bugzilla – Bug 355995
New object for draw the systems security
Last modified: 2007-06-10 17:39:04 UTC
I propose you a new object to draw the security of system. yhos object is associate whith sheet object.
Created attachment 72805 [details] this zip file add sheet and object part
Created attachment 74349 [details] [review] add to sissi.sheet.in I had forget the sSISSI.sheet.in Know it's correct
When this is ready for inclusion this would be an enhancement. To make the process more transparent here's my comment written in private mail: From my understanding if we accept it in cvs we should be prepared to maintain it. So I looked a little deeper in the code and found more questions than answers. Here are some of them: * the SISSI objects is the second one directly using XML (custom being the first). But instead of using a well defined XML dialect (like SVG) it seems to abuse Dia's native format to re-store it's custom information. It is reading french tags from a (standard?) diagram file. My french is not good enough to understand what it really does, but to me this looks like a serious misconception. * a bunch of code is 'out-commented' without a comment if it should be fixed or deleted * sissi_object_set_props() is put in the objects v-table but does nothing at all. This can't be right, cause it means all the StdProps benefits are gone (like undo, simple serialization, etc.) * there is a mix of XPM and PNG in the sheets/SISSI folder and also some GIFs. Probably there only should be PNG. * functions, variables, comments and tags are partly in french in contrast to the rest of Dia being almost completely in english. For me this would make maintenance much harder * Steffen: I just noticed you were adding the sissi objects to the plug-ins folder/makefile. An oversight or am I missing something? So I think there is quite some work to be done before we should include SISSI with Dia. Oh, and Lars mentioned that the main sheets language should be english.
Created attachment 78800 [details] [review] new version in full english This is a new version of my project rewrite in full English and optimize.
I think there is still some French left, but Luc seems to be committed to work on the integration of the things. I'm ready to switch all images to PNG and review everything for French vocabulary again. Hans, maybe you have time to look at your comments again. Or better: Luc, could you answer on all of Hans' points? Maybe you did this already in an email, in this case it would be nice if you could post this here.
Created attachment 83623 [details] [review] new version full english Steffen, I think that I have clear all French, I can't switch all images to PNG. Hans * a bunch of code is 'out-commented' without a comment if it should be fixed or deleted Know I think it's OK * sissi_object_set_props() is put in the objects v-table but does nothing at all. This can't be right, cause it means all the StdProps benefits are gone (like undo, simple serialization, etc.) There were not very much explication I program for make that I would. I worked that I could to do theses Objects, which are very different that all objects of DIA. * functions, variables, comments and tags are partly in french in contrast to the rest of Dia being almost completely in english. For me this would make maintenance much harder Know it is OK * Steffen: I just noticed you were adding the sissi objects to the plug-ins folder/makefile. An oversight or am I missing something? Excuse me, it's an error of me. Thank for your Attention. Luc
Marking for 0.97 as we won't be putting it in at the last moment.
Created attachment 85904 [details] [review] Bug correction I correct a small bug in asking xml file, and I have perfected the physics objects which are more perform know.
Trying to compile the 2007-04-06 version, I get an error that clear_list_property_menace() is not defined. Lars, Hans: as 0.96 is out now, is this ready to be committed to the repository from your side?
Created attachment 86124 [details] [review] correction of menace.c I am sorry, a bad copy past on menace.c
Sorry, I'm still missing clear_list_property_menace() in the updated attachment.
Created attachment 86159 [details] [review] I had published a bad zip file
From my understanding there are still two important questions not answered yet. To make them more clear let me try to rephrase them: - are we prepared to maintain it ? [ I'm currently not due to lack of time and also lack of application. As far as I can tell I simply wont have any use case for drawing "system security" ] - should we allow abuse of Dia's native format include in Dia? [ The XML files in sheets/SISSI still start as if they were Dia diagram files. Loading them produces Error loading diagram: D:\graph\dia2\sheets\SISSI\37.xml. A valid Dia file defines at least one layer. which is *not* correct cause they are no diagram files. I think the fix would be rather easy: just dont use: <dia:diagram xmlns:dia="http://www.lysator.liu.se/~alla/dia/"> but instead something like <dia:sissi xmlns:dia="http://sissi.fr/just-a-globally-unique-id/"> It should be relative straight-forward to fix this in code by replacing the respective strings in sissi/*.c and the *,xml files. I'm still considering the diagram format abuse as blocker for inclusion. ]
Hans, thanks for the clarification! Regarding the first point: I think that Luc has shown willingness to maintain/improve the plug-in. I would therefore vote to inlcude it, once the second point is solved. Luc: Can you work on the second point?
Created attachment 86225 [details] [review] Correction of NameSpace I have corrected the namespace but I want to keep this file structure for use the dia function to read xml file. I have not problems with 37.xml file
Nive response time, thanks. So let's include sissi in SVN it to get further things out. BTW: it would be nice to have a representative sample diagram available. I'm still a little bit lost how this diagram type is supposed to be used ;-)
I've committed the patch.
(In reply to comment #17) > I've committed the patch. > Could you build a dll file for windows? I would like test with. Tank before
This patch has introduced a lot of french strings in the .po files, was that expected? please use english. thanks.
I'm reviewing the sources and the sheet once more. I've changed the following. Please correct me if my translations are wrong (Neither french nor english native speaker): * confidentialite to confidentiality * Don't know what libelle is, asked Luc for this * "Boitier de chiffrement" to "cipher machine" * "Analyse de log" to "Log analysis" * "Cage de faraday" to "Faraday cage" * "Site geographique" to "Geographic site" * "capteur brise glace" to "Glass-break sensor" * "capteur faisceau" to "Sensor beam" * "condensateur" to "condensator" * "detecteur d'alimentation" to "power transducer" Will continue with the review later.
More translations in SISSI.sheet.in: * "detecteur de courant" to "current transducer" * "detecteur enthalpie" to "enthalpy transducer" * "detecteur de fumee" to "smoke detector" * "detecteur de niveau" to "level detector" * "pompe rotative" to "circulation pump" * "porte tambour" to "revolving door" Plus some more... I hope that all French terms for translation are gone now. If I missed something, please let me know