GNOME Bugzilla – Bug 355979
No copy disc option
Last modified: 2007-01-09 20:16:19 UTC
That bug has been opened onhttps://launchpad.net/distros/ubuntu/+source/nautilus-cd-burner/+bug/60405 "On right clicking on a disc, there is no copy option. This is with Edgy. This option was there with Dapper. I am using the AMD64 version, but it shouldn't affect this."
Odd. It works fine here. The one change we made in this cycle was to not show the option if the disc is blank. Can you post the output of list_cddrives (included in the n-c-b sources) with the disc in question in the drive? Thanks.
Created attachment 72794 [details] list_cddrives output I have two CD drives, the first one is the one being used in this case. I think the output of the second drive would lead to another instance of bug #350082.
Are you right clicking on the drive (in Computer folder) or the volume (on the desktop)? The copy item will appear on the volume but not the drive.
I am right clicking on the drive in the computer folder, as I have switched off volumes being shown on the desktop. I just re-enabled them, and right clicking on the icon on the desktop works. Why do the options not appear when right clicking on the icon in Computer?
I think it changed as a result of bug 326173. I guess there is nothing wrong with having it on the drive too. Part of it is due to implementation detail because the blank property is on the volume (ie. media) and not the drive. I guess it is more correct this way - you aren't copying the drive but the volume (media). If someone has a patch I'd probably apply it.
Unfortunately, I can't program, so I can't provide a patch for this myself.
Created attachment 76675 [details] [review] proposed patch Would this patch help? it's very simplistic but i don't see anything smarter to do in that case? It does work for me. if there is a drive info, but no volume info, then we get the first volume in the drive and check if that volume is blank. otherwise nothing is changed. let me know if this patch is not good (and why) and I'll rework it. i think that that feature should really work in "computer" as well as on the desktop. for the user it's really the same thing.
Created attachment 76677 [details] [review] move curly bracket moved the curly bracket "{" on the same line as the "if" to respect the coding style of the project. no other changes.
please don't forget about this bug/patch. it would be too bad if it can't make it for 2.18. it's a really small change, and it makes thing really better for people who disabled icons on the desktop or volumes on the desktop (which is a supported configuration).
Created attachment 79772 [details] [review] reworked patch Your patch had a few problems. * variable defined in middle of block doesn't comply with c89 * else if should be on same line as closing brace of if block * c++ style comments are not allowed * align variable names in definitions * better not to include function calls in variable definitions * the g_list_first call isn't needed I'm going to commit this reworked patch. Can you please verify that it works? Thank you.
Created attachment 79773 [details] [review] updated Oops, make sure to unref.
Committed and seems to work for me.
I confirm, the SVN version fixes the problem for me.