After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355945 - CVS HEAD fails to build with -O3
CVS HEAD fails to build with -O3
Status: RESOLVED FIXED
Product: rhythmbox
Classification: Other
Component: general
HEAD
Other Linux
: Normal normal
: ---
Assigned To: RhythmBox Maintainers
RhythmBox Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-14 11:54 UTC by Christian Becke
Modified: 2006-09-14 12:13 UTC
See Also:
GNOME target: ---
GNOME version: 2.13/2.14


Attachments
patch against widgets/rb-entry-view.c (304 bytes, patch)
2006-09-14 11:58 UTC, Christian Becke
committed Details | Review

Description Christian Becke 2006-09-14 11:54:21 UTC
Building CVS HEAD with -O3 optimization fails with the following error:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\"/usr/local/share/locale\" -DG_LOG_DOMAIN=\"Rhythmbox\" -I.. -I../lib -I../lib -I../player -I../metadata -I../rhythmdb -I../sources -I../library -I../iradio -I../shell -I../backends -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -DLIBNOTIFY_VERSION_MAJOR=0 -DLIBNOTIFY_VERSION_MINOR=4 -DLIBNOTIFY_VERSION_MICRO=2 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/libxml2 -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -Wcomment -Wformat -Wnonnull -Wimplicit-int -Wimplicit -Wmain -Wmissing-braces -Wparentheses -Wsequence-point -Wreturn-type -Wswitch -Wtrigraphs -Wunused-function -Wunused-label -Wunused-value -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wall -Werror -std=gnu89 -O3 -march=athlon-xp -fomit-frame-pointer -pipe -MT rb-entry-view.lo -MD -MP -MF .deps/rb-entry-view.Tpo -c rb-entry-view.c -o rb-entry-view.o >/dev/null 2>&1
make[3]: *** [rb-entry-view.lo] Error 1
make[3]: Leaving directory `/home/chris/rhythmbox/widgets'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/chris/rhythmbox/widgets'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/chris/rhythmbox'
make: *** [all] Error 2

Manually running the last gcc command fails with the following error:

gcc -DHAVE_CONFIG_H -I. -I. -I.. -DGNOMELOCALEDIR=\"/usr/local/share/locale\" -DG_LOG_DOMAIN=\"Rhythmbox\" -I.. -I../lib -I../lib -I../player -I../metadata -I../rhythmdb -I../sources -I../library -I../iradio -I../shell -I../backends -I/usr/include/gtk-2.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -DLIBNOTIFY_VERSION_MAJOR=0 -DLIBNOTIFY_VERSION_MINOR=4 -DLIBNOTIFY_VERSION_MICRO=2 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/libxml2 -DORBIT2=1 -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libgnomeui-2.0 -I/usr/include/libgnome-2.0 -I/usr/include/libgnomecanvas-2.0 -I/usr/include/libart-2.0 -I/usr/include/gconf/2 -I/usr/include/libbonoboui-2.0 -I/usr/include/gnome-vfs-2.0 -I/usr/lib/gnome-vfs-2.0/include -I/usr/include/gnome-keyring-1 -I/usr/include/orbit-2.0 -I/usr/include/libbonobo-2.0 -I/usr/include/bonobo-activation-2.0 -I/usr/include/freetype2 -I/usr/include/libxml2 -I/usr/include/libglade-2.0 -I/usr/include/gnome-vfs-module-2.0 -pthread -I/usr/include/gstreamer-0.10 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libxml2 -Wcomment -Wformat -Wnonnull -Wimplicit-int -Wimplicit -Wmain -Wmissing-braces -Wparentheses -Wsequence-point -Wreturn-type -Wswitch -Wtrigraphs -Wunused-function -Wunused-label -Wunused-value -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wall -Werror -std=gnu89 -O3 -march=athlon-xp -fomit-frame-pointer -pipe -MT rb-entry-view.lo -MD -MP -MF .deps/rb-entry-view.Tpo -c rb-entry-view.c -o rb-entry-view.o
cc1: warnings being treated as errors
rb-entry-view.c: In function 'rb_entry_view_sync_sorting':
rb-entry-view.c:853: warning: 'direction' may be used uninitialized in this function

This only happens with -O3, it builds alright with -O2. This is with gcc-4.1.1 on Gentoo.
Comment 1 Christian Becke 2006-09-14 11:58:45 UTC
Created attachment 72769 [details] [review]
patch against widgets/rb-entry-view.c

Initializes "direction" in "rb_entry_view_sync_sorting" with GTK_SORT_ASCENDING.
Is this a sensible default here?
Comment 2 Jonathan Matthew 2006-09-14 12:13:39 UTC
Committed to CVS.  Thanks for picking this up.  The "default" sort order doesn't really matter, as it'll never be used.