GNOME Bugzilla – Bug 355912
Missing symbols in atk.def
Last modified: 2006-09-14 14:55:11 UTC
I found some missing symbols in atk.def. These functions, not exported to DLL, are required to build pygtk and gtkmm on win32. The attached patch is against CVS HEAD but should also be applied to at 1.10 and atk-1.12.
Created attachment 72752 [details] [review] Add missing symbols to atk.def
Is there a document somewhere aimed at gnome/gtk+ developers that explains how I can keep the .def file up to date myself?
committed to HEAD. Please commit to 1.10 and 1.12.
Maybe you should ask Tor for the best way of keeping .def file up to date. I see 2 solutions here: 1. Automatically export all symbols at build time with "-no-undefined -Wl,--export-all-symbols" for mingw32 or a tool called gendef for MSVC. This is the approach we use for glibmm/gtkmm because of differences in the C++ mangling system used by the various compilers. 2. Parse the header files as done by pygtk (codegen/defsgen.py creates .defs files which are used to create the bindings). Quite interestingly, glibmm/gtkmm also uses those .defs file for its own code generation. About the commit to 1.10 and 1.12, should I do it myself or somebody else will take care of it ?
Thanks Cedric, I'll ask Tor. >About the commit to 1.10 and 1.12, should I do it myself or somebody else will >take care of it ? If you would do this Cedric it would help me a lot. Thanks very much!
(In reply to comment #5) > >About the commit to 1.10 and 1.12, should I do it myself or somebody else will > >take care of it ? > > If you would do this Cedric it would help me a lot. Thanks very much! Did it for 1.10 (gnome-2.12 branch). As far as I can see 1.12 hasn't been branched yet (gnome-2.14 corresponds to 1.11) so I guess it is still CVS HEAD. Correct me if I'm wrong.
Thanks Cedric; you are right, so this is now complete.