After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355858 - switching image forward and back quickly can display wrong image
switching image forward and back quickly can display wrong image
Status: RESOLVED FIXED
Product: eog
Classification: Core
Component: collection
git master
Other Linux
: Normal normal
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-13 20:18 UTC by Felix Riemann
Modified: 2006-09-28 13:25 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
proposed fix for eog-ng branch (893 bytes, patch)
2006-09-14 10:06 UTC, Felix Riemann
none Details | Review

Description Felix Riemann 2006-09-13 20:18:28 UTC
This showed up while I was making tests to find the memory leak I observed in bug #333595. (I'll open another bug about that one later)

How to reproduce:
1. Open an image (Image1) from a collection of several images.
2. Click the Next-Button to load the next image (Image2) from the collection.
3. While Image2 is still loading click the Previous-Button to return to Image1.

What's happening?
Image2 completes loading and is displayed while Image1 is selected in the collection.

This is also reproducable on the eog-ng branch.

It works fine if you skip&return 2 images.
Comment 1 Felix Riemann 2006-09-14 10:06:15 UTC
Created attachment 72763 [details] [review]
proposed fix for eog-ng branch

This little fix ensures that the current loading job is cancelled for sure when the selection is changed and re-hides the statusbar afterwards.
If it is okay I'll commit it.

I couldn't find a fix for the current stable branch yet.
Comment 2 Felix Riemann 2006-09-18 10:40:10 UTC
I commited the fix for eog-ng:

2006-09-18  Felix Riemann  <friemann@cvs.gnome.org>

	* shell/eog-window.c: (eog_window_clear_load_job),
	(handle_image_selection_changed_cb): make sure a possible loading job
	is cancelled when re-selecting the current image (Fixes bug #355858).

I'm still trying to find a good fix for the stable branch (by trying not to change a lot of code).
Comment 3 Felix Riemann 2006-09-28 13:25:27 UTC
Okay, I found a fix for the other branches too:

2006-09-28  Felix Riemann 

	* shell/eog-window.c: (handle_image_selection_changed): Make sure the
	correct image is displayed when reselecting the current image while
	loading another one (Fixes bug #355858).

Commited to HEAD and gnome-2-16.