After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355513 - panel launchers get emptied after left mouse button drag&dropping twice
panel launchers get emptied after left mouse button drag&dropping twice
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
2.16.x
Other Linux
: Normal normal
: ---
Assigned To: Panel Maintainers
Panel Maintainers
: 424558 425484 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2006-09-11 23:11 UTC by Sebastien Bacher
Modified: 2007-05-12 21:40 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16


Attachments
gconf .xml for the launcher object when first created (1.85 KB, text/plain)
2006-10-20 21:45 UTC, Thomas M Steenholdt
  Details
gconf .xml for the new launcher object after the first left-button-move (1.82 KB, text/plain)
2006-10-20 21:45 UTC, Thomas M Steenholdt
  Details
gconf .xml for the new new launcher object after the second left-button-move (1.83 KB, text/plain)
2006-10-20 21:46 UTC, Thomas M Steenholdt
  Details
a patch (699 bytes, patch)
2006-11-14 22:29 UTC, Matthias Clasen
needs-work Details | Review
proposed patch (1.15 KB, patch)
2006-12-06 15:24 UTC, padraig.obriain
none Details | Review

Description Sebastien Bacher 2006-09-11 23:11:46 UTC
That bug has been opened on https://launchpad.net/distros/ubuntu/+source/gnome-panel/+bug/59431

"Version: current Edgy, on two different computers

A panel launcher loses all of its contents after it has been moved on the panel with the left mouse button twice.

Steps to recreate:
- Add a panel launcher
- Click and holde the left mouse button, move to a different location, then release the button
- Repeat the last step
- The panel launcher's icon changes to the "icon missing" icon, and looking at the icon's settings reveals that the Name, Command and Description fields are empty.

This does not happen when using the middle mouse button to move the launchers.
..."
Comment 1 Richard Schwarting 2006-09-15 04:50:37 UTC
This is happening to me too.  I first thought it was happening only to ones I defined myself but then ones that I dragged from the Applications menu onto panel started emptying out when I moved them along the panel with my left-click.
Comment 2 hans 2006-10-20 05:15:18 UTC
I am also experiencing this problem with gnome-panel 2.16.1 in Ubuntu Edgy
Comment 3 Thomas M Steenholdt 2006-10-20 20:34:31 UTC
Same thing here!
Comment 4 Thomas M Steenholdt 2006-10-20 21:44:14 UTC
fwiw, this is what appears to be happening (object xml files will follow):

1) I create the initial launcher by dragging it from the applications menu onto the panel (object_8_just_created.xml). The launcher still points to the file:///usr/share/applications...desktop file.

2) Moving the launcher around with the middle button appears to work fine, but trying to move it, even just slightly, with the left mouse button makes the following happen:

   - the original launcher object is destroyed and a new one is created, pointing to a new randomly named file.
   - the randomly named .desktop file is created under the ~/.gnome2/panel.d/default/launchers/ directory.

At this stage, the launher appears to still be working. It's icon still looks normal and so on (object_9_first_moved.xml).

3) Trying to move the launcher with left mouse button once more, however, hits this bug. The following is what happens:

   - the launcher object is destroyed and a new one is created, pointing to a NEW randomly named file.
   - the NEW randomly named file is NOT created under the ~/.gnome2/panel.d/default/launchers/ directory.

At this stage the launcher icon is substitued for a "?" icon and properties for the laucher is all blank. Needless to say that the launcher is toast at this point (object_8_second_moved.xml).

Hopefully this will provide you guys with enough info to solve this bug quickly. Recreation of custom launchers is starting to annoy me ;-)
Comment 5 Thomas M Steenholdt 2006-10-20 21:45:11 UTC
Created attachment 75107 [details]
gconf .xml for the launcher object when first created
Comment 6 Thomas M Steenholdt 2006-10-20 21:45:56 UTC
Created attachment 75108 [details]
gconf .xml for the new launcher object after the first left-button-move
Comment 7 Thomas M Steenholdt 2006-10-20 21:46:41 UTC
Created attachment 75109 [details]
gconf .xml for the new new launcher object after the second left-button-move
Comment 8 Peter Vander Klippe 2006-11-11 16:24:23 UTC
I also have this problem. Does not always only happen the second time. This problem can easily occur the first time you do it.

Running Gnome 2.16.1 on Ubuntu Edgy updated till November 11, 2006.

If you click and drag a panel icon with the left mouse button, the panel icon moves but is cleared of all its contents. (missing icon, command, title, etc) This happens most times.

If you lock the panel icons, then you avoid this problem, but your icons are then locked.

Middle mouse button moving doesn't cause this problem.

This is really frustrating as you can easily move the mouse while clicking the icon, causing you to lose the shortcut. If you have a whole bunch of custom icons, this is really annoying.
Comment 9 Matthias Clasen 2006-11-14 22:29:15 UTC
Created attachment 76602 [details] [review]
a patch

This patch fixes the problem.
Comment 10 Vincent Untz 2006-11-14 22:59:39 UTC
Thanks for the patch. I believe it'd be better to fix the bug in launcher.c:drag_data_get_cb() since it's broken in the same way for TARGET_URI_LIST.
Comment 11 Matthias Clasen 2006-11-16 21:25:45 UTC
makes sense.
Also, there is a stupid typo in my patch:

source_uri = gnome_vfs_uri_new (location);

should  be

source_uri = gnome_vfs_uri_new (path);
Comment 12 padraig.obriain 2006-12-06 15:24:49 UTC
Created attachment 77822 [details] [review]
proposed patch

This patch fixes the problem for me for a launcher. What is the test case TARGET_URI_LIST?
Comment 13 Vincent Untz 2007-01-14 22:17:39 UTC
Fixed in trunk.
Padraig: your patch modified the gconf values, I believe, which is not the best way to do it.
Comment 14 Sebastien Bacher 2007-04-23 13:44:02 UTC
*** Bug 424558 has been marked as a duplicate of this bug. ***
Comment 15 Vincent Untz 2007-05-12 21:40:21 UTC
*** Bug 425484 has been marked as a duplicate of this bug. ***