After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355353 - gthumb should build when srcdir != objdir
gthumb should build when srcdir != objdir
Status: RESOLVED FIXED
Product: gthumb
Classification: Other
Component: general
2.7.x
Other All
: Normal minor
: ---
Assigned To: Paolo Bacchilega
Paolo Bacchilega
Depends on:
Blocks:
 
 
Reported: 2006-09-10 23:12 UTC by marty leisner
Modified: 2006-11-30 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to libgthumb/Makefile.am (2.25 KB, patch)
2006-09-10 23:15 UTC, marty leisner 		none Details | Review
Makefile.am patch to build with srcdir != objdir (2.68 KB, patch)
2006-09-26 01:24 UTC, marty leisner 		none Details | Review

Description marty leisner 2006-09-10 23:12:45 UTC 
Please describe the problem:
If srcdir != objdir, gthumb should build sucessfully.

All generated files should go into objdir, srcdir should be left
alone.

See attached patch to libgthumb/Makefile.am (which isn't sufficient,
since -I$(objdir)/libgthumb needs to be added to the src path

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?
yes

Other information:
Comment 1 marty leisner 2006-09-10 23:15:13 UTC 
Created attachment 72518 [details] [review]
patch to libgthumb/Makefile.am

also, it seems we don't have to be dependent on glib-mkenums -- if we're not, $^ works at finding the header files with VPATH.

Other things also have to change to find the generated headers in objdir.
Comment 2 marty leisner 2006-09-26 01:24:42 UTC 
Created attachment 73407 [details] [review]
Makefile.am patch to build with srcdir != objdir
Comment 3 Paolo Bacchilega 2006-10-01 11:08:48 UTC 
fixed in CVS, thanks.
Comment 4 marty leisner 2006-10-05 14:55:59 UTC 
cvs version didn't quite work right, redoing the patch.

Generated files should be in objdir, not srcdir (we should be able to make when src file system is readonly)
Comment 5 Paolo Bacchilega 2006-11-30 15:04:50 UTC 
patch applied to CVS, thanks.