After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 355117 - Use ● instead of * for masking passwords
Use ● instead of * for masking passwords
Status: RESOLVED INVALID
Product: gossip
Classification: Deprecated
Component: General
0.15
Other Linux
: Normal minor
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-09 13:39 UTC by Xavier Claessens
Modified: 2006-09-16 08:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (765 bytes, patch)
2006-09-09 13:41 UTC, Xavier Claessens 		none Details | Review
forgotten some entries (16.80 KB, patch)
2006-09-10 09:46 UTC, Xavier Claessens 		none Details | Review
still one missing (17.38 KB, patch)
2006-09-10 12:03 UTC, Xavier Claessens 		committed Details | Review

Description Xavier Claessens 2006-09-09 13:39:54 UTC 
Most GNOME applications uses now ● for masking passwords. It's now the default when creating a GtkEntry in Glade.
Comment 1 Xavier Claessens 2006-09-09 13:41:00 UTC 
Created attachment 72452 [details] [review]
proposed patch
Comment 2 Xavier Claessens 2006-09-10 09:46:07 UTC 
Created attachment 72489 [details] [review]
forgotten some entries

Replaced everywhere to be sure ;-)
Comment 3 Martyn Russell 2006-09-10 11:29:06 UTC 
I would imagine you have forgotten the password dialog used when connecting to your account which is generated from source, in src/gossip-ui-utils.c I think.b
Comment 4 Xavier Claessens 2006-09-10 12:03:33 UTC 
Created attachment 72498 [details] [review]
still one missing

Thanks, you were right.
Comment 5 Richard Hult 2006-09-10 20:05:14 UTC 
I think you are mistaken GNOME apps for ubuntu patches for GNOME apps... this is not something that should be done on an app-by-app basis imo, it should be changed in GTK+ if anywhere.
Comment 6 Richard Hult 2006-09-10 20:08:05 UTC 
Gah, I hit send before I was done. Of course, if -I- am mistaken, the patch looks great and should be committed :)
Comment 7 Martyn Russell 2006-09-11 07:06:55 UTC 
Committed thanks ;)

Also, please don't set the subject to use [PATCH], there is no need and it just takes up subject line space. The subject is now used when generating the NEWS for new releases, so we don't need to include any unnecessary wordings and Bugzilla has patch support so we see everything your submit :D
Comment 8 Richard Hult 2006-09-14 17:01:01 UTC 
Did someone actually bother to check if it's just ubuntu or if GNOME is doing this? I'm really not so sure about it, since it's a pretty bad way to solve this (it should be changed in GTK+ instead of in all apps, if changed at all).

Plus is doesn't work for me, I just get question marks in my password entries.
Comment 9 Xavier Claessens 2006-09-14 17:27:21 UTC 
Olav Vitters has marked the patch as accepted. I asked Seb128 (ubuntu GNOME packager) and he confirmed it is ubuntu specific. So it should be reverted if you think it's a bad idea for upstream.
Comment 10 Olav Vitters 2006-09-14 17:30:27 UTC 
Whoops. Seems I didn't read comment 6 fully. I only read "the patch looks great and should be committed".
Comment 11 Richard Hult 2006-09-14 17:39:43 UTC 
No problem :) I do think we should revert though and leave the default and let ubuntu patch if they want to.
Comment 12 Richard Hult 2006-09-16 08:22:42 UTC 
Reverted in CVS.