After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 354771 - Completion strings for status presets dialog not remembered after restart
Completion strings for status presets dialog not remembered after restart
Status: VERIFIED FIXED
Product: gossip
Classification: Deprecated
Component: General
0.15
Other Linux
: Normal normal
: ---
Assigned To: Gossip Maintainers
Gossip Maintainers
Depends on:
Blocks:
 
 
Reported: 2006-09-07 14:26 UTC by Wouter Bolsterlee (uws)
Modified: 2006-09-17 12:59 UTC
See Also:
GNOME target: ---
GNOME version: 2.15/2.16

Attachments
proposed patch (2.57 KB, patch)
2006-09-13 19:34 UTC, Xavier Claessens 		none Details | Review
fixed (2.62 KB, patch)
2006-09-13 20:12 UTC, Xavier Claessens 		none Details | Review

Description Wouter Bolsterlee (uws) 2006-09-07 14:26:24 UTC 
The dropdown select box in the "custom message" status dialog is not populated with the existing values after a Gossip restart. Newly added items are added correctly, though,
Comment 1 Martyn Russell 2006-09-07 14:31:12 UTC 
I give you permission to write a patch for once ;)
Comment 2 Xavier Claessens 2006-09-13 18:12:02 UTC 
I can reproduce this bug.
Comment 3 Xavier Claessens 2006-09-13 19:34:37 UTC 
Created attachment 72718 [details] [review]
proposed patch

add presets status in the drop down menu and when adding a status checks if it doesn't exists yet.
Comment 4 Richard Hult 2006-09-13 19:47:35 UTC 
Nice, thanks. A few comments:

* The call to gtk_tree_model_get leaks str.

* There should also be some aligning of variables and an empty line between variable declarations and code.
Comment 5 Xavier Claessens 2006-09-13 20:12:20 UTC 
Created attachment 72720 [details] [review]
fixed
Comment 6 Richard Hult 2006-09-14 16:38:21 UTC 
Thanks, looks good to me :)
Comment 7 Richard Hult 2006-09-16 08:12:30 UTC 
Thannk! I'm not sure if this is exactly what Wouter meant (the patch uses the saved presets, not any old strings you might have entered before but not saved). I've committed this, and we can file new bugs to tweak the behavior if necessary.
Comment 8 Wouter Bolsterlee (uws) 2006-09-17 12:59:02 UTC 
This is what I meant (saved strings not saved after restart). Unsaved strings (most likely temporary status msgs) should not be remembered... what else is the "save" option for? ;)